Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: components/translate/core/browser/translate_ui_delegate_unittest.cc

Issue 2726043003: Revert "[translate] Add translate ranker model loader." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_ui_delegate.h" 5 #include "components/translate/core/browser/translate_ui_delegate.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "base/strings/stringprintf.h" 11 #include "base/strings/stringprintf.h"
12 #include "build/build_config.h" 12 #include "build/build_config.h"
13 #include "components/infobars/core/infobar.h" 13 #include "components/infobars/core/infobar.h"
14 #include "components/pref_registry/pref_registry_syncable.h" 14 #include "components/pref_registry/pref_registry_syncable.h"
15 #include "components/sync_preferences/testing_pref_service_syncable.h" 15 #include "components/sync_preferences/testing_pref_service_syncable.h"
16 #include "components/translate/core/browser/mock_translate_driver.h" 16 #include "components/translate/core/browser/mock_translate_driver.h"
17 #include "components/translate/core/browser/mock_translate_ranker.h"
18 #include "components/translate/core/browser/translate_client.h" 17 #include "components/translate/core/browser/translate_client.h"
19 #include "components/translate/core/browser/translate_infobar_delegate.h" 18 #include "components/translate/core/browser/translate_infobar_delegate.h"
20 #include "components/translate/core/browser/translate_manager.h" 19 #include "components/translate/core/browser/translate_manager.h"
21 #include "components/translate/core/browser/translate_prefs.h" 20 #include "components/translate/core/browser/translate_prefs.h"
22 #include "components/variations/variations_associated_data.h" 21 #include "components/variations/variations_associated_data.h"
23 #include "testing/gmock/include/gmock/gmock.h" 22 #include "testing/gmock/include/gmock/gmock.h"
24 #include "testing/gtest/include/gtest/gtest.h" 23 #include "testing/gtest/include/gtest/gtest.h"
25 #include "url/gurl.h" 24 #include "url/gurl.h"
26 25
27 using testing::Return; 26 using testing::Return;
28 using testing::Test; 27 using testing::Test;
29 using translate::testing::MockTranslateDriver; 28 using translate::testing::MockTranslateDriver;
30 using translate::testing::MockTranslateRanker;
31 29
32 namespace translate { 30 namespace translate {
33 31
34 #if defined(OS_CHROMEOS) 32 #if defined(OS_CHROMEOS)
35 const char* preferred_languages_prefs = "settings.language.preferred_languages"; 33 const char* preferred_languages_prefs = "settings.language.preferred_languages";
36 #else 34 #else
37 const char* preferred_languages_prefs = NULL; 35 const char* preferred_languages_prefs = NULL;
38 #endif 36 #endif
39 37
40 class MockTranslateClient : public TranslateClient { 38 class MockTranslateClient : public TranslateClient {
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 78
81 void SetUp() override { 79 void SetUp() override {
82 pref_service_.reset(new sync_preferences::TestingPrefServiceSyncable()); 80 pref_service_.reset(new sync_preferences::TestingPrefServiceSyncable());
83 pref_service_->registry()->RegisterStringPref( 81 pref_service_->registry()->RegisterStringPref(
84 "settings.language.preferred_languages", std::string()); 82 "settings.language.preferred_languages", std::string());
85 pref_service_->registry()->RegisterStringPref("intl.accept_languages", 83 pref_service_->registry()->RegisterStringPref("intl.accept_languages",
86 std::string()); 84 std::string());
87 TranslatePrefs::RegisterProfilePrefs(pref_service_->registry()); 85 TranslatePrefs::RegisterProfilePrefs(pref_service_->registry());
88 86
89 client_.reset(new MockTranslateClient(&driver_, pref_service_.get())); 87 client_.reset(new MockTranslateClient(&driver_, pref_service_.get()));
90 ranker_.reset(new MockTranslateRanker()); 88
91 manager_.reset(new TranslateManager(client_.get(), ranker_.get(), "hi")); 89 manager_.reset(new TranslateManager(client_.get(), "hi"));
92 manager_->GetLanguageState().set_translation_declined(false); 90 manager_->GetLanguageState().set_translation_declined(false);
93 91
94 delegate_.reset( 92 delegate_.reset(
95 new TranslateUIDelegate(manager_->GetWeakPtr(), "ar", "fr")); 93 new TranslateUIDelegate(manager_->GetWeakPtr(), "ar", "fr"));
96 94
97 ASSERT_FALSE(client_->GetTranslatePrefs()->IsTooOftenDenied("ar")); 95 ASSERT_FALSE(client_->GetTranslatePrefs()->IsTooOftenDenied("ar"));
98 } 96 }
99 97
100 // Do not reorder. These are ordered for dependency on creation/destruction.
101 MockTranslateDriver driver_; 98 MockTranslateDriver driver_;
99 std::unique_ptr<MockTranslateClient> client_;
102 std::unique_ptr<sync_preferences::TestingPrefServiceSyncable> pref_service_; 100 std::unique_ptr<sync_preferences::TestingPrefServiceSyncable> pref_service_;
103 std::unique_ptr<MockTranslateClient> client_;
104 std::unique_ptr<MockTranslateRanker> ranker_;
105 std::unique_ptr<TranslateManager> manager_; 101 std::unique_ptr<TranslateManager> manager_;
106 std::unique_ptr<TranslateUIDelegate> delegate_; 102 std::unique_ptr<TranslateUIDelegate> delegate_;
107 103
108 private: 104 private:
109 DISALLOW_COPY_AND_ASSIGN(TranslateUIDelegateTest); 105 DISALLOW_COPY_AND_ASSIGN(TranslateUIDelegateTest);
110 }; 106 };
111 107
112 TEST_F(TranslateUIDelegateTest, CheckDeclinedFalse) { 108 TEST_F(TranslateUIDelegateTest, CheckDeclinedFalse) {
113 std::unique_ptr<TranslatePrefs> prefs(client_->GetTranslatePrefs()); 109 std::unique_ptr<TranslatePrefs> prefs(client_->GetTranslatePrefs());
114 for (int i = 0; i < 10; i++) { 110 for (int i = 0; i < 10; i++) {
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 prefs->IncrementTranslationAcceptedCount("ar"); 196 prefs->IncrementTranslationAcceptedCount("ar");
201 197
202 EXPECT_FALSE(delegate_->ShouldAlwaysTranslateBeCheckedByDefault()); 198 EXPECT_FALSE(delegate_->ShouldAlwaysTranslateBeCheckedByDefault());
203 } 199 }
204 200
205 // TODO(ftang) Currently this file only test TranslationDeclined(), we 201 // TODO(ftang) Currently this file only test TranslationDeclined(), we
206 // need to add the test for other functions soon to increase the test 202 // need to add the test for other functions soon to increase the test
207 // coverage. 203 // coverage.
208 204
209 } // namespace translate 205 } // namespace translate
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698