rietveld.py - Issue 27260007: GTTF: When faking urllib2.HTTPError use int type for HTTP error code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rietveld.py

Issue 27260007: GTTF: When faking urllib2.HTTPError use int type for HTTP error code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: rietveld.py

diff --git a/rietveld.py b/rietveld.py

index aa5897e626094cb4b738d110286334634c3cccf5..7e476fb6d58aa0c0ea12d23483e32e447e14db85 100644

--- a/rietveld.py

+++ b/rietveld.py

@@ -365,7 +365,8 @@ class Rietveld(object):

m = re.search(r'(50\d) Server Error', msg)

if m:

# Fake an HTTPError exception. Cheezy. :(

- raise urllib2.HTTPError(request_path, m.group(1), msg, None, None)

+ raise urllib2.HTTPError(

+ request_path, int(m.group(1)), msg, None, None)

old_error_exit(msg)

upload.ErrorExit = trap_http_500

« no previous file with comments | « no previous file | no next file » | no next file with comments »