Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 2725993002: Move page closing hang timer duties to its own timer. (Closed)
Patch Set: comment excision Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <list> 10 #include <list>
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 273
274 // Instructs the various live views to stop. Called when the user directed the 274 // Instructs the various live views to stop. Called when the user directed the
275 // page to stop loading. 275 // page to stop loading.
276 void Stop(); 276 void Stop();
277 277
278 // Notifies the regular and pending RenderViewHosts that a load is or is not 278 // Notifies the regular and pending RenderViewHosts that a load is or is not
279 // happening. Even though the message is only for one of them, we don't know 279 // happening. Even though the message is only for one of them, we don't know
280 // which one so we tell both. 280 // which one so we tell both.
281 void SetIsLoading(bool is_loading); 281 void SetIsLoading(bool is_loading);
282 282
283 // Whether to close the tab or not when there is a hang during an unload
284 // handler. If we are mid-crosssite navigation, then we should proceed
285 // with the navigation instead of closing the tab.
286 bool ShouldCloseTabOnUnresponsiveRenderer();
Charlie Reis 2017/03/03 01:05:59 Hooray! This is exactly what I hoped to get out o
Avi (use Gerrit) 2017/03/03 01:25:25 Acknowledged.
287
288 // Confirms whether we should close the page or navigate away. This is called 283 // Confirms whether we should close the page or navigate away. This is called
289 // before a cross-site request or before a tab/window is closed (as indicated 284 // before a cross-site request or before a tab/window is closed (as indicated
290 // by the first parameter) to allow the appropriate renderer to approve or 285 // by the first parameter) to allow the appropriate renderer to approve or
291 // deny the request. |proceed| indicates whether the user chose to proceed. 286 // deny the request. |proceed| indicates whether the user chose to proceed.
292 // |proceed_time| is the time when the request was allowed to proceed. 287 // |proceed_time| is the time when the request was allowed to proceed.
293 void OnBeforeUnloadACK(bool for_cross_site_transition, 288 void OnBeforeUnloadACK(bool for_cross_site_transition,
294 bool proceed, 289 bool proceed,
295 const base::TimeTicks& proceed_time); 290 const base::TimeTicks& proceed_time);
296 291
297 // The |pending_render_frame_host| is ready to commit a page. We should 292 // The |pending_render_frame_host| is ready to commit a page. We should
(...skipping 511 matching lines...) Expand 10 before | Expand all | Expand 10 after
809 std::unique_ptr<RenderFrameHostImpl> speculative_render_frame_host_; 804 std::unique_ptr<RenderFrameHostImpl> speculative_render_frame_host_;
810 805
811 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_; 806 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_;
812 807
813 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager); 808 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager);
814 }; 809 };
815 810
816 } // namespace content 811 } // namespace content
817 812
818 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 813 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698