Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2725983002: Add a data structure to keep track of modifiers in AstBuilder. (Closed)

Created:
3 years, 9 months ago by Paul Berry
Modified:
3 years, 9 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a data structure to keep track of modifiers in AstBuilder. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/70408f75496468cf751b32566a7688c7ef65e99a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -73 lines) Patch
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 15 chunks +62 lines, -73 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 9 months ago (2017-03-01 22:30:46 UTC) #2
scheglov
LGTM
3 years, 9 months ago (2017-03-01 22:36:54 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 70408f75496468cf751b32566a7688c7ef65e99a (presubmit successful).
3 years, 9 months ago (2017-03-01 22:43:16 UTC) #5
ahe
3 years, 9 months ago (2017-03-02 06:16:10 UTC) #6
Message was sent while issue was closed. 
lgtm

Sweet!

Powered by Google App Engine
This is Rietveld 408576698