third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp - Issue 2725893002: Media Controls timeline: immediately update current time display

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Issue 2725893002: Media Controls timeline: immediately update current time display (Closed)

Patch Set: Mark media/controls-drag-timebar-rendering.html failing, see crbug.com/699096 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

index 8bc5052f76bbfc6dbdc72146772a104c0f6a140d..73ac65b2156e8e06d59acc2c83d42889e1141bc0 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

@@ -807,9 +807,9 @@ void MediaControlTimelineElement::defaultEventHandler(Event* event) {

if (mediaElement().seekable()->contain(time))

mediaElement().setCurrentTime(time);

- LayoutSliderItem slider = LayoutSliderItem(toLayoutSlider(layoutObject()));

- if (!slider.isNull() && slider.inDragMode())

- mediaControls().updateCurrentTimeDisplay();

+ // Provide immediate feedback (without waiting for media to seek) to make it

+ // easier for user to seek to a precise time.

+ mediaControls().updateCurrentTimeDisplay();

}

bool MediaControlTimelineElement::willRespondToMouseClickEvents() {