Media: fix memory leak because of the document holding on an EventListener.

third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights
  * reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 82 matching lines @@
 #include "public/platform/modules/remoteplayback/WebRemotePlaybackAvailability.h"
 #include "public/platform/modules/remoteplayback/WebRemotePlaybackClient.h"
 #include "public/platform/modules/remoteplayback/WebRemotePlaybackState.h"
 #include "wtf/AutoReset.h"
 #include "wtf/CurrentTime.h"
 #include "wtf/MathExtras.h"
 #include "wtf/PtrUtil.h"
 #include "wtf/text/CString.h"
 
 #ifndef BLINK_MEDIA_LOG
-#define BLINK_MEDIA_LOG DVLOG(3)
+#define BLINK_MEDIA_LOG LOG(INFO)
 #endif
 
 #ifndef LOG_MEDIA_EVENTS
 // Default to not logging events because so many are generated they can
 // overwhelm the rest of the logging.
 #define LOG_MEDIA_EVENTS 0
 #endif
 
 #ifndef LOG_OFFICIAL_TIME_STATUS
 // Default to not logging status of official time because it adds a fair amount
@@ skipping 375 matching lines @@
   // m_audioSourceNode is explicitly cleared by AudioNode::dispose().
   // Since AudioNode::dispose() is guaranteed to be always called before
   // the AudioNode is destructed, m_audioSourceNode is explicitly cleared
   // even if the AudioNode and the HTMLMediaElement die together.
   DCHECK(!m_audioSourceNode);
 }
 
 void HTMLMediaElement::dispose() {
   closeMediaSource();
 
+  LOG(INFO) << "HTMLMediaElement::dispose";
+
   // Destroying the player may cause a resource load to be canceled,
   // which could result in LocalDOMWindow::dispatchWindowLoadEvent() being
   // called via ResourceFetch::didLoadResource(), then
   // FrameLoader::checkCompleted(). But it's guaranteed that the load event
   // doesn't get dispatched during the object destruction.
   // See Document::isDelayingLoadEvent().
   // Also see http://crbug.com/275223 for more details.
   clearMediaPlayerAndAudioSourceProviderClientWithoutLocking();
 }
 
@@ skipping 138 matching lines @@
         m_networkState == kNetworkEmpty) {
       m_ignorePreloadNone = false;
       invokeLoadAlgorithm();
     }
   }
 
   return InsertionShouldCallDidNotifySubtreeInsertions;
 }
 
 void HTMLMediaElement::didNotifySubtreeInsertionsToDocument() {
+  BLINK_MEDIA_LOG << "didNotifySubtreeInsertionsToDocument()";
   updateControlsVisibility();
 }
 
 void HTMLMediaElement::removedFrom(ContainerNode* insertionPoint) {
   BLINK_MEDIA_LOG << "removedFrom(" << (void*)this << ", " << insertionPoint
                   << ")";
 
   HTMLElement::removedFrom(insertionPoint);
   if (insertionPoint->inActiveDocument()) {
     updateControlsVisibility();
+    m_mediaControls->detach();
+    m_mediaControls = nullptr;
     if (m_networkState > kNetworkEmpty)
       pauseInternal();
   }
 }
 
 void HTMLMediaElement::attachLayoutTree(const AttachContext& context) {
   HTMLElement::attachLayoutTree(context);
 
   if (layoutObject())
     layoutObject()->updateFromElement();
@@ skipping 3120 matching lines @@
 void HTMLMediaElement::mediaSourceOpened(WebMediaSource* webMediaSource) {
   setShouldDelayLoadEvent(false);
   m_mediaSource->setWebMediaSourceAndOpen(WTF::wrapUnique(webMediaSource));
 }
 
 bool HTMLMediaElement::isInteractiveContent() const {
   return fastHasAttribute(controlsAttr);
 }
 
 DEFINE_TRACE(HTMLMediaElement) {
+  LOG(INFO) << "HTMLMediaElement::trace";
   visitor->trace(m_playedTimeRanges);
   visitor->trace(m_asyncEventQueue);
   visitor->trace(m_error);
   visitor->trace(m_currentSourceNode);
   visitor->trace(m_nextChildNodeToConsider);
   visitor->trace(m_mediaSource);
   visitor->trace(m_audioTracks);
   visitor->trace(m_videoTracks);
   visitor->trace(m_cueTimeline);
   visitor->trace(m_textTracks);
@@ skipping 358 matching lines @@
       kMostlyFillViewportBecomeStableSeconds, BLINK_FROM_HERE);
 }
 
 void HTMLMediaElement::viewportFillDebouncerTimerFired(TimerBase*) {
   m_mostlyFillingViewport = true;
   if (m_webMediaPlayer)
     m_webMediaPlayer->becameDominantVisibleContent(m_mostlyFillingViewport);
 }
 
 }  // namespace blink