chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java - Issue 2725813004: Init WebApkUpdateManager with a WebappDataStorage to avoid null object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

Issue 2725813004: Init WebApkUpdateManager with a WebappDataStorage to avoid null object. (Closed)

Patch Set: Split onDeferredStorage Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

index 465425083260a8537f2e046436a0ad26ad8841e1..db5fffa4c1835ef085a619de28c653ab7602f310 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

@@ -59,8 +59,8 @@ public class WebApkUpdateManagerTest extends ChromeTabbedActivityTestBase {

private CallbackHelper mWaiter;

private boolean mNeedsUpdate = false;

- public TestWebApkUpdateManager(CallbackHelper waiter) {

- super(null);

+ public TestWebApkUpdateManager(CallbackHelper waiter, WebappDataStorage storage) {

+ super(null, storage);

mWaiter = waiter;

}

@@ -147,7 +147,8 @@ public class WebApkUpdateManagerTest extends ChromeTabbedActivityTestBase {

/** Checks whether a WebAPK update is needed. */

private boolean checkUpdateNeeded(final CreationData creationData) throws Exception {

CallbackHelper waiter = new CallbackHelper();

- final TestWebApkUpdateManager updateManager = new TestWebApkUpdateManager(waiter);

+ WebappDataStorage storage = WebappRegistry.getInstance().getWebappDataStorage(WEBAPK_ID);

+ final TestWebApkUpdateManager updateManager = new TestWebApkUpdateManager(waiter, storage);

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override