Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: third_party/WebKit/Source/wtf/HashSet.h

Issue 2725813002: (CANCELED) Forbid GC during copyToVector() (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/HashCountedSet.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 304
305 template <typename T, typename U, typename V, typename W> 305 template <typename T, typename U, typename V, typename W>
306 inline auto HashSet<T, U, V, W>::takeAny() -> ValueType { 306 inline auto HashSet<T, U, V, W>::takeAny() -> ValueType {
307 return take(begin()); 307 return take(begin());
308 } 308 }
309 309
310 template <typename C, typename W> 310 template <typename C, typename W>
311 inline void copyToVector(const C& collection, W& vector) { 311 inline void copyToVector(const C& collection, W& vector) {
312 typedef typename C::const_iterator iterator; 312 typedef typename C::const_iterator iterator;
313 313
314 { 314 // Disallow GC across resize and iterations, see crbug.com/568173
315 // Disallow GC across resize allocation, see crbug.com/568173 315 typename W::GCForbiddenScope scope;
316 typename W::GCForbiddenScope scope; 316
317 vector.resize(collection.size()); 317 vector.resize(collection.size());
318 }
319 318
320 iterator it = collection.begin(); 319 iterator it = collection.begin();
321 iterator end = collection.end(); 320 iterator end = collection.end();
322 for (unsigned i = 0; it != end; ++it, ++i) 321 for (unsigned i = 0; it != end; ++it, ++i)
323 vector[i] = *it; 322 vector[i] = *it;
324 } 323 }
325 324
326 } // namespace WTF 325 } // namespace WTF
327 326
328 using WTF::HashSet; 327 using WTF::HashSet;
329 328
330 #endif // WTF_HashSet_h 329 #endif // WTF_HashSet_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/wtf/HashCountedSet.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698