Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4909)

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

Issue 2725783004: views: align columns in site settings dialog (Closed)
Patch Set: fix unit tests, document stuff Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.h
diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
index 0a5e46107c9a778bc15accbc0720e9582e73021a..d03423eb56a43fd1762bc712159e38d4a8488ebd 100644
--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
@@ -11,6 +11,7 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "chrome/browser/ui/views/website_settings/chosen_object_row_observer.h"
+#include "chrome/browser/ui/views/website_settings/permission_selector_row.h"
#include "chrome/browser/ui/views/website_settings/permission_selector_row_observer.h"
#include "chrome/browser/ui/website_settings/website_settings_ui.h"
#include "content/public/browser/web_contents_observer.h"
@@ -172,6 +173,11 @@ class WebsiteSettingsPopupView : public content::WebContentsObserver,
// The certificate provided by the site, if one exists.
scoped_refptr<net::X509Certificate> certificate_;
+ // The permission row objects; these bundle together all the Views involved in
+ // a single row of the permission section, and are responsible for keeping
+ // those Views updated when the underlying Permission changes.
+ std::vector<std::unique_ptr<PermissionSelectorRow>> selector_rows_;
+
base::WeakPtrFactory<WebsiteSettingsPopupView> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(WebsiteSettingsPopupView);

Powered by Google App Engine
This is Rietveld 408576698