Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2725773002: Remove NGBlockNode constructor, SetFirstChild, SetNextSibling methods (Closed)
Patch Set: git cl web Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
index 5a1abf690a32b83b879a9620ae4030864001183c..1f3c4d01136612d5d0e3b0ead30f3940b26eb9aa 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
@@ -103,6 +103,10 @@ NGConstraintSpace* NGConstraintSpace::CreateFromLayoutObject(
NGPhysicalSize initial_containing_block_size{
LayoutUnit(icb_float_size.width()), LayoutUnit(icb_float_size.height())};
+ // ICB cannot be indefinite by the spec.
+ DCHECK_GE(initial_containing_block_size.width, LayoutUnit());
+ DCHECK_GE(initial_containing_block_size.height, LayoutUnit());
+
return NGConstraintSpaceBuilder(writing_mode)
.SetAvailableSize(available_size)
.SetPercentageResolutionSize(percentage_size)
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698