third_party/WebKit/Source/core/layout/ng/ng_block_node.h - Issue 2725773002: Remove NGBlockNode constructor, SetFirstChild, SetNextSibling methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.h

Issue 2725773002: Remove NGBlockNode constructor, SetFirstChild, SetNextSibling methods (Closed)

Patch Set: git cl web Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_block_node.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node.h b/third_party/WebKit/Source/core/layout/ng/ng_block_node.h

index 04d2311e1beacf9d607584453f08260a4921c2ef..7b7a145564dc5c3b8eb8fa6c2a2b96bc2a64c47e 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node.h

@@ -29,9 +29,6 @@ class CORE_EXPORT NGBlockNode final : public NGLayoutInputNode {

public:

explicit NGBlockNode(LayoutObject*);

- // TODO(layout-ng): make it private and declare a friend class to use in tests

- explicit NGBlockNode(ComputedStyle*);

~NGBlockNode() override;

RefPtr<NGLayoutResult> Layout(NGConstraintSpace* constraint_space,

@@ -51,9 +48,6 @@ class CORE_EXPORT NGBlockNode final : public NGLayoutInputNode {

NGLayoutInputNode* FirstChild();

- void SetNextSibling(NGLayoutInputNode*);

- void SetFirstChild(NGLayoutInputNode*);

DECLARE_VIRTUAL_TRACE();

// Runs layout on layout_box_ and creates a fragment for the resulting