Issue 2725753002: [Cleanup] Add an explicit threading assertion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2725753002: [Cleanup] Add an explicit threading assertion. (Closed)

Created:
3 years, 9 months ago by Ilya Sherman

Modified:
3 years, 9 months ago

Reviewers:
Tobias Sargeant

CC:
chromium-reviews, kalyank, sadrul, android-webview-reviews_chromium.org, agrieve+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Cleanup] Add an explicit threading assertion. BUG=none TEST=none R=tobiasjs@chromium.org

Patch Set 1 #

Total comments: 1

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploaderImpl.java	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Tobias Sargeant

3 years, 9 months ago (2017-03-01 08:04:44 UTC) #2

https://codereview.chromium.org/2725753002/diff/1/android_webview/java/src/or...
File
android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploaderImpl.java
(right):

https://codereview.chromium.org/2725753002/diff/1/android_webview/java/src/or...
android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploaderImpl.java:136:
ThreadUtils.assertOnUiThread();
This looks ok, but it's not consistent with the comment (which mentions "this
thread" in a way that says that it might be called on multiple threads). If the
commandline data structure is constant after initialization, do we need restrict
it to a single thread?

Expand Messages | Collapse Messages