content/public/browser/child_process_security_policy.h - Issue 272573005: <webview>: Move NewWindow API to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/child_process_security_policy.h

Issue 272573005: <webview>: Move NewWindow API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_rename

Patch Set: Addressed Istiaque's comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/browser_plugin_guest_delegate.h ('K') | « content/public/browser/browser_plugin_guest_delegate.cc ('k') | content/public/browser/content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/child_process_security_policy.h

diff --git a/content/public/browser/child_process_security_policy.h b/content/public/browser/child_process_security_policy.h

index 261bf58f1810ee8d559a83149a44b222f2c8039b..8a63c38aeb6eb401139f28a17855e63222d83d5c 100644

--- a/content/public/browser/child_process_security_policy.h

+++ b/content/public/browser/child_process_security_policy.h

@@ -40,6 +40,9 @@ class ChildProcessSecurityPolicy {

// Returns true iff |scheme| has been registered as a web-safe scheme.

virtual bool IsWebSafeScheme(const std::string& scheme) = 0;

+ // Returns true iff |scheme| has been registered as a pseudo-scheme

jam 2014/05/13 21:38:25 do we really want to expose this concept outside c

Fady Samuel 2014/05/15 20:02:57 We need to support about:, but that's it. We don't

+ virtual bool IsPseudoScheme(const std::string& scheme) = 0;

// This permission grants only read access to a file.

// Whenever the user picks a file from a <input type="file"> element, the

// browser should call this function to grant the child process the capability