Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5284)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 272573005: <webview>: Move NewWindow API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_rename
Patch Set: Addressed Istiaque's comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 821d4b11b1d01a211ec7c206efbe30b2a59cf1b3..a61a2fa4296fa26e488229d3400b84630ab5f6d8 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -812,6 +812,7 @@ content::WebContentsViewDelegate*
}
void ChromeContentBrowserClient::GuestWebContentsCreated(
+ int guest_instance_id,
SiteInstance* guest_site_instance,
WebContents* guest_web_contents,
WebContents* opener_web_contents,
@@ -851,10 +852,10 @@ void ChromeContentBrowserClient::GuestWebContentsCreated(
// Create a new GuestViewBase of the same type as the opener.
*guest_delegate = GuestViewBase::Create(
+ guest_instance_id,
guest_web_contents,
extension_id,
- guest->GetViewType(),
- guest->AsWeakPtr());
+ guest->GetViewType());
return;
}
@@ -869,10 +870,10 @@ void ChromeContentBrowserClient::GuestWebContentsCreated(
return;
*guest_delegate =
- GuestViewBase::Create(guest_web_contents,
+ GuestViewBase::Create(guest_instance_id,
+ guest_web_contents,
extension_id,
- api_type,
- base::WeakPtr<GuestViewBase>());
+ api_type);
}
void ChromeContentBrowserClient::GuestWebContentsAttached(

Powered by Google App Engine
This is Rietveld 408576698