chrome/browser/search_engines/template_url_service_unittest.cc - Issue 272573004: Handle TemplateURLService load failure better, and make some test correctness fixes that will be ne…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/template_url_service_unittest.cc

Issue 272573004: Handle TemplateURLService load failure better, and make some test correctness fixes that will be ne… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase after revert / presubmit fixes. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/search_engines/template_url_service_unittest.cc

diff --git a/chrome/browser/search_engines/template_url_service_unittest.cc b/chrome/browser/search_engines/template_url_service_unittest.cc

index d6ca7383315d166ae3a6c0c2e27301e6817be2ca..5237b7e75b47f32e6ec26e79fe69ecd3d6d88c24 100644

--- a/chrome/browser/search_engines/template_url_service_unittest.cc

+++ b/chrome/browser/search_engines/template_url_service_unittest.cc

@@ -500,7 +500,7 @@ TEST_F(TemplateURLServiceTest, AddSameKeyword) {

data.safe_for_autoreplace = false;

TemplateURL* t_url2 = new TemplateURL(test_util_.profile(), data);

model()->Add(t_url2);

- VerifyObserverCount(2);

+ VerifyObserverCount(1);

EXPECT_EQ(t_url2, model()->GetTemplateURLForKeyword(ASCIIToUTF16("keyword")));

EXPECT_EQ(ASCIIToUTF16("fourth"), t_url2->short_name());

EXPECT_EQ(ASCIIToUTF16("keyword"), t_url2->keyword());

« no previous file with comments | « chrome/browser/search_engines/template_url_service.cc ('k') | chrome/browser/ui/browser_instant_controller.h » ('j') | no next file with comments »