chrome/browser/search/instant_service_observer.h - Issue 272573004: Handle TemplateURLService load failure better, and make some test correctness fixes that will be ne…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/instant_service_observer.h

Issue 272573004: Handle TemplateURLService load failure better, and make some test correctness fixes that will be ne… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/search/instant_service.cc ('K') | « chrome/browser/search/instant_service.cc ('k') | chrome/browser/search/instant_service_observer.cc » ('j') | chrome/browser/ui/browser_instant_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search/instant_service_observer.h

diff --git a/chrome/browser/search/instant_service_observer.h b/chrome/browser/search/instant_service_observer.h

index 248b689471892141264d66900df6d18f01f3557f..68b4c973196b403b5fe73c076628d199eb02f329 100644

--- a/chrome/browser/search/instant_service_observer.h

+++ b/chrome/browser/search/instant_service_observer.h

@@ -23,11 +23,6 @@ class InstantServiceObserver {

// Indicates that the default search provider changed.

virtual void DefaultSearchProviderChanged();

- // Indicates that the Google URL has changed as a result of searchdomaincheck.

- // Note that the search domain change triggers a yellow infobar at the top of

- // the page, and the actual change is triggered after the user accepts.

- virtual void GoogleURLUpdated();

// Indicates that the omnibox start margin has changed.

virtual void OmniboxStartMarginChanged(int omnibox_start_margin);