Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2725623002: Fix a type error in reify/transformation/builder.dart. (Closed)

Created:
3 years, 9 months ago by asgerf
Modified:
3 years, 9 months ago
Reviewers:
Dmitry Stefantsov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a type error in reify/transformation/builder.dart. A call to toList was missing after .map(). BUG= R=dmitryas@google.com Committed: https://github.com/dart-lang/sdk/commit/ccaff30f0038b51be0b209929ece5ddced4508eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/kernel/lib/transformations/reify/transformation/builder.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
3 years, 9 months ago (2017-02-28 12:31:03 UTC) #2
Dmitry Stefantsov
LGTM
3 years, 9 months ago (2017-02-28 12:32:43 UTC) #3
asgerf
3 years, 9 months ago (2017-02-28 12:38:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ccaff30f0038b51be0b209929ece5ddced4508eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698