Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

Issue 2725603002: createFragmentFromMarkupWithContext() should use EphemeralRange. (Closed)
Patch Set: Y Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
diff --git a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp b/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
index 794b7cedd64da049c5e3a5630dec9f97d295c63d..a65da56900eae87ff0ea8952a697f674551e834b 100644
--- a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
+++ b/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
@@ -408,12 +408,11 @@ DocumentFragment* createFragmentFromMarkupWithContext(
root->appendChild(taggedFragment);
taggedDocument->appendChild(root);
- Range* range = Range::create(
- *taggedDocument,
+ const EphemeralRange range(
Position::afterNode(nodeBeforeContext).parentAnchoredEquivalent(),
Position::beforeNode(nodeAfterContext).parentAnchoredEquivalent());
- Node* commonAncestor = range->commonAncestorContainer();
+ Node* commonAncestor = range.commonAncestorContainer();
HTMLElement* specialCommonAncestor =
ancestorToRetainStructureAndAppearanceWithNoLayoutObject(commonAncestor);

Powered by Google App Engine
This is Rietveld 408576698