Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/WebKit/Source/core/editing/EphemeralRange.h

Issue 2725603002: createFragmentFromMarkupWithContext() should use EphemeralRange. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EphemeralRange.h
diff --git a/third_party/WebKit/Source/core/editing/EphemeralRange.h b/third_party/WebKit/Source/core/editing/EphemeralRange.h
index 2116b2c661f26e15225db78c5dafe069f7a1cc93..c9f8883fcbb1e83e8e81863704e0be91942fcb08 100644
--- a/third_party/WebKit/Source/core/editing/EphemeralRange.h
+++ b/third_party/WebKit/Source/core/editing/EphemeralRange.h
@@ -105,6 +105,9 @@ class CORE_TEMPLATE_CLASS_EXPORT EphemeralRangeTemplate final {
PositionTemplate<Strategy> startPosition() const;
PositionTemplate<Strategy> endPosition() const;
+ Node* commonAncestorContainer() const;
Xiaocheng 2017/02/28 19:26:31 Could you add unit tests for this new function? A
tanvir 2017/03/02 14:59:14 I have added the unit test cases for DOM and FlatT
tanvir 2017/03/02 14:59:14 Done.
+ static Node* commonAncestorContainer(const Node* containerA, const Node* containerB);
Xiaocheng 2017/02/28 19:26:31 There's no need to expose this function, as there'
tanvir 2017/03/02 14:59:14 Done.
+
// Returns true if |m_startPositoin| == |m_endPosition| or |isNull()|.
bool isCollapsed() const;
bool isNull() const {

Powered by Google App Engine
This is Rietveld 408576698