createFragmentFromMarkupWithContext() should use EphemeralRange.

third_party/WebKit/Source/core/editing/EphemeralRange.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/EphemeralRange.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/Range.h"
 #include "core/dom/Text.h"
 
 namespace blink {
 
+namespace {
+

[Xiaocheng, 2017/03/02 20:00:16]

nit: remove this extra blank line.

[tanvir, 2017/03/04 13:55:31]

Done.

+template <typename Strategy>
+Node* commonAncestorContainerNode(const Node* containerA,
+                                  const Node* containerB) {
+  if (!containerA || !containerB)
+    return nullptr;
+  return Strategy::commonAncestor(*containerA, *containerB);
+}
+}
+
 template <typename Strategy>
 EphemeralRangeTemplate<Strategy>::EphemeralRangeTemplate(
     const PositionTemplate<Strategy>& start,
     const PositionTemplate<Strategy>& end)
     : m_startPosition(start),
       m_endPosition(end)
 #if DCHECK_IS_ON()
       ,
       m_domTreeVersion(start.isNull() ? 0 : start.document()->domTreeVersion())
 #endif
@@ skipping 78 matching lines @@
 }
 
 template <typename Strategy>
 PositionTemplate<Strategy> EphemeralRangeTemplate<Strategy>::endPosition()
     const {
   DCHECK(isValid());
   return m_endPosition;
 }
 
 template <typename Strategy>
+Node* EphemeralRangeTemplate<Strategy>::commonAncestorContainer() const {
+  return commonAncestorContainerNode<Strategy>(
+      m_startPosition.computeContainerNode(),
+      m_endPosition.computeContainerNode());
+}
+
+template <typename Strategy>
 bool EphemeralRangeTemplate<Strategy>::isCollapsed() const {
   DCHECK(isValid());
   return m_startPosition == m_endPosition;
 }
 
 template <typename Strategy>
 typename EphemeralRangeTemplate<Strategy>::RangeTraversal
 EphemeralRangeTemplate<Strategy>::nodes() const {
   return RangeTraversal(m_startPosition.nodeAsRangeFirstNode(),
                         m_endPosition.nodeAsRangePastLastNode());
@@ skipping 25 matching lines @@
     return nullptr;
   return Range::create(range.document(), range.startPosition(),
                        range.endPosition());
 }
 
 template class CORE_TEMPLATE_EXPORT EphemeralRangeTemplate<EditingStrategy>;
 template class CORE_TEMPLATE_EXPORT
     EphemeralRangeTemplate<EditingInFlatTreeStrategy>;
 
 }  // namespace blink