createFragmentFromMarkupWithContext() should use EphemeralRange.

third_party/WebKit/Source/core/editing/EphemeralRange.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/EphemeralRange.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/Range.h"
 #include "core/dom/Text.h"
@@ skipping 91 matching lines @@
 }
 
 template <typename Strategy>
 PositionTemplate<Strategy> EphemeralRangeTemplate<Strategy>::endPosition()
     const {
   DCHECK(isValid());
   return m_endPosition;
 }
 
 template <typename Strategy>
+Node* EphemeralRangeTemplate<Strategy>::commonAncestorContainer() const
+{
+    return commonAncestorContainer(m_startPosition.computeContainerNode(), m_endPosition.computeContainerNode());
+}
+
+template <typename Strategy>
+Node* EphemeralRangeTemplate<Strategy>::commonAncestorContainer(const Node* containerA, const Node* containerB)
+{
+    if (!containerA || !containerB)
+        return nullptr;
+    return containerA->commonAncestor(*containerB, NodeTraversal::parent);

[Xiaocheng, 2017/02/28 19:26:31]

Should return |Strategy::commonAncestor(*containerA, *containerB)| instead.

EphemeralRangeTemplate<> is a templated class that can be used on either DOM
tree or flat tree, depending on the template parameter |Strategy|.

Strategy::commonAncestor allows us to compute the common ancestor in either of
the trees in a templated manner. On the other hand, NodeTraversal::parent only
allows computing common ancestor in the DOM tree.

[tanvir, 2017/03/02 14:59:14]

Done.

+}
+
+template <typename Strategy>
 bool EphemeralRangeTemplate<Strategy>::isCollapsed() const {
   DCHECK(isValid());
   return m_startPosition == m_endPosition;
 }
 
 template <typename Strategy>
 typename EphemeralRangeTemplate<Strategy>::RangeTraversal
 EphemeralRangeTemplate<Strategy>::nodes() const {
   return RangeTraversal(m_startPosition.nodeAsRangeFirstNode(),
                         m_endPosition.nodeAsRangePastLastNode());
@@ skipping 25 matching lines @@
     return nullptr;
   return Range::create(range.document(), range.startPosition(),
                        range.endPosition());
 }
 
 template class CORE_TEMPLATE_EXPORT EphemeralRangeTemplate<EditingStrategy>;
 template class CORE_TEMPLATE_EXPORT
     EphemeralRangeTemplate<EditingInFlatTreeStrategy>;
 
 }  // namespace blink