Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2725563003: Add some tests for calls with checks in strong mode. (Closed)

Created:
3 years, 9 months ago by asgerf
Modified:
3 years, 9 months ago
Reviewers:
Dmitry Stefantsov, Leaf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add some tests for calls with checks in strong mode. Tests checks due to covariant subtyping, dynamic calls, and their interaction with tear-offs. The tests use explicit type annotations so they can run independently of frontend type inference. R=dmitryas@google.com, leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/ea4a89ba03de84598b7b1051820e5a2e068ab059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -13 lines) Patch
A + tests/language_strong/covariant_subtyping_tearoff1_test.dart View 1 chunk +7 lines, -2 lines 0 comments Download
A + tests/language_strong/covariant_subtyping_tearoff2_test.dart View 1 chunk +8 lines, -3 lines 0 comments Download
A tests/language_strong/covariant_subtyping_tearoff3_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
M tests/language_strong/covariant_subtyping_unsafe_call1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/covariant_subtyping_unsafe_call2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A tests/language_strong/covariant_subtyping_unsafe_call3_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A + tests/language_strong/tearoff_dynamic_test.dart View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
asgerf
Leaf: I am hoping, as someone who knows strong mode, you can help verify that ...
3 years, 9 months ago (2017-02-28 13:47:35 UTC) #2
Dmitry Stefantsov
LGTM
3 years, 9 months ago (2017-02-28 15:23:49 UTC) #3
Leaf
lgtm, thanks!
3 years, 9 months ago (2017-02-28 19:12:03 UTC) #4
asgerf
3 years, 9 months ago (2017-03-01 10:28:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ea4a89ba03de84598b7b1051820e5a2e068ab059 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698