chrome/test/data/webui/media_router/media_router_container_route_tests.js - Issue 2725503002: [Media Router] Custom Controls 4 - Implement details view WebUI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/media_router/media_router_container_route_tests.js

Issue 2725503002: [Media Router] Custom Controls 4 - Implement details view WebUI (Closed)

Patch Set: Address Mark's comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/media_router/media_router_ui_interface.js ('K') | « chrome/browser/ui/webui/media_router/media_router_resources_provider.cc ('k') | chrome/test/data/webui/media_router/media_router_elements_browsertest.js » ('j') | chrome/test/data/webui/media_router/route_controls_tests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/media_router/media_router_container_route_tests.js

diff --git a/chrome/test/data/webui/media_router/media_router_container_route_tests.js b/chrome/test/data/webui/media_router/media_router_container_route_tests.js

index 71a41e8814cab291dd83000f511e06619489e615..eb5a80a74a7864e1f2a52b602997f52420e9888a 100644

--- a/chrome/test/data/webui/media_router/media_router_container_route_tests.js

+++ b/chrome/test/data/webui/media_router/media_router_container_route_tests.js

@@ -254,7 +254,8 @@ cr.define('media_router_container_route', function() {

// Tests for expected visible UI when the view is ROUTE_DETAILS.

test('route details visibility', function(done) {

- container.showRouteDetails_();

+ container.showRouteDetails_(

+ new media_router.Route('id 3', 'sink id 3', 'Title 3', 0, true));

setTimeout(function() {

checkElementsVisibleWithId(['container-header',

'device-missing',

@@ -294,7 +295,8 @@ cr.define('media_router_container_route', function() {

// Tests for expected visible UI when the view is ROUTE_DETAILS, and there

// is a non-blocking issue.

test('route details visibility non blocking issue', function(done) {

- container.showRouteDetails_();

+ container.showRouteDetails_(

+ new media_router.Route('id 3', 'sink id 3', 'Title 3', 0, true));

// Set a non-blocking issue. The issue should be shown.

container.issue = fakeNonBlockingIssue;

@@ -309,7 +311,8 @@ cr.define('media_router_container_route', function() {

// Tests for expected visible UI when the view is ROUTE_DETAILS, and there

// is a blocking issue.

test('route details visibility with blocking issue', function(done) {

- container.showRouteDetails_();

+ container.showRouteDetails_(

+ new media_router.Route('id 3', 'sink id 3', 'Title 3', 0, true));

// Set a blocking issue. The issue should be shown, and everything

// else, hidden.