Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <link rel="import" href="chrome://resources/html/polymer.html"> | 1 <link rel="import" href="chrome://resources/html/polymer.html"> |
| 2 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> | 2 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> |
| 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> |
| 4 <link rel="import" href="extension_view_wrapper/extension_view_wrapper.html"> | |
| 5 <link rel="import" href="../route_controls/route_controls.html"> | |
| 4 <dom-module id="route-details"> | 6 <dom-module id="route-details"> |
| 5 <link rel="import" type="css" href="../../media_router_common.css"> | 7 <link rel="import" type="css" href="../../media_router_common.css"> |
| 6 <link rel="import" type="css" href="route_details.css"> | 8 <link rel="import" type="css" href="route_details.css"> |
| 7 <template> | 9 <template> |
| 8 <div id="route-information" hidden$="[[!isCustomControllerHidden_]]"> | 10 <div id="route-information" |
| 11 hidden$="[[!shouldShowRouteInfoOnly_(controllerType_)]]"> | |
| 9 <span>[[activityStatus_]]</span> | 12 <span>[[activityStatus_]]</span> |
| 10 </div> | 13 </div> |
| 11 <extensionview id="custom-controller" | 14 <template is="dom-if" if="[[!useWebUiRouteControls]]"> |
| 12 hidden$="[[isCustomControllerHidden_]]"> | 15 <extension-view-wrapper id="extension-view-wrapper" route="[[route]]" |
| 13 </extensionview> | 16 is-extension-view-ready="{{isExtensionViewReady}}" |
| 17 hidden$="[[!shouldShowExtensionView_(controllerType_)]]"> | |
| 18 </extension-view-wrapper> | |
| 19 </template> | |
| 20 <route-controls id="route-controls" | |
|
apacible
2017/05/17 21:52:17
What are the pros/cons of keeping <route-controls>
takumif
2017/05/18 18:01:55
Actually, since we'll be comparing the load times
apacible
2017/05/24 20:28:26
SGTM.
| |
| 21 hidden$="[[!shouldShowWebUiControls_(controllerType_)]]"> | |
| 22 </route-controls> | |
| 14 <div id="route-action-buttons" class="layout"> | 23 <div id="route-action-buttons" class="layout"> |
| 15 <paper-button flat class="route-button button" | 24 <paper-button flat class="route-button button" |
| 16 id="start-casting-to-route-button" | 25 id="start-casting-to-route-button" |
| 17 hidden$="[[computeCastButtonHidden_(route, changeRouteSourceAvailable_ )]]" | 26 hidden$="[[computeCastButtonHidden_(route, changeRouteSourceAvailable_ )]]" |
| 18 on-tap="startCastingToRoute_"> | 27 on-tap="startCastingToRoute_"> |
| 19 <span>[[i18n('startCastingButtonText')]]</span> | 28 <span>[[i18n('startCastingButtonText')]]</span> |
| 20 </paper-button> | 29 </paper-button> |
| 21 <paper-button flat class="route-button button" | 30 <paper-button flat class="route-button button" |
| 22 id="close-route-button" | 31 id="close-route-button" |
| 23 on-tap="closeRoute_"> | 32 on-tap="closeRoute_"> |
| 24 <span>[[i18n('stopCastingButtonText')]]</span> | 33 <span>[[i18n('stopCastingButtonText')]]</span> |
| 25 </paper-button> | 34 </paper-button> |
| 26 <div> | 35 <div> |
| 27 </template> | 36 </template> |
| 28 <script src="route_details.js"></script> | 37 <script src="route_details.js"></script> |
| 29 </dom-module> | 38 </dom-module> |
| OLD | NEW |