chrome/browser/resources/media_router/elements/route_controls/route_controls.html - Issue 2725503002: [Media Router] Custom Controls 4 - Implement details view WebUI

Side by Side Diff: chrome/browser/resources/media_router/elements/route_controls/route_controls.html

Issue 2725503002: [Media Router] Custom Controls 4 - Implement details view WebUI (Closed)

Patch Set: Address Derek's comments, don't load extensionview unnecessarily Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js ('K') | « chrome/browser/resources/media_router/elements/route_controls/route_controls.css ('k') | chrome/browser/resources/media_router/elements/route_controls/route_controls.js » ('j') | chrome/browser/resources/media_router/elements/route_controls/route_controls.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/html/i18n_behavior.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/av-icons.htm l">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-slider/paper-slid er.html">

	5 <dom-module id="route-controls">

	6 <link rel="import" type="css" href="../../media_router_common.css">

	7 <link rel="import" type="css" href="route_controls.css">

	8 <template>

	9 <div id="media-controls">

	10 <div class="ellipsis" id="route-description"

	11 title="[[displayedDescription_]]">

	12 [[displayedDescription_]]
	mark a. foltz 2017/05/12 00:02:46 This is the route status description or route desc This is the route status description or route description, correct? takumif 2017/05/15 17:13:12 Yes. And route status description takes precedence Show quoted text On 2017/05/12 00:02:46, mark a. foltz wrote: > This is the route status description or route description, correct? Yes. And route status description takes precedence over route description.
	13 </div>

	14 <div class="ellipsis" id="route-title" title="[[routeStatus.title]]">

	15 [[routeStatus.title]]

	16 </div>

	17 <div>

	18 <div id="route-time-controls" hidden="[[!routeStatus.canSeek]]">

	19 <paper-slider

	20 id="route-time-slider"

	21 on-change="onSeekComplete_"

	22 on-immediate-value-change="onSeekStart_"

	23 min="0" max="[[routeStatus.duration]]" step="1"

	24 title="[[i18n('seekTitle')]]"

	25 value="[[displayedCurrentTime_]]"></paper-slider>

	26 <div id="timeline">

	27 <span id="current-time">

	28 [[getFormattedTime_(displayedCurrentTime_)]]

	29 </span>

	30 <span id="duration">

	31 [[getFormattedTime_(routeStatus.duration)]]

	32 </span>

	33 </div>

	34 </div>

	35 <div id="play-pause-volume-controls">

	36 <span id="button-holder">

	37 <paper-icon-button

	38 id="route-play-pause-button"

	39 hidden="[[!routeStatus.canPlayPause]]"

	40 disabled="[[!routeStatus.canPlayPause]]"

	41 icon="[[getPlayPauseIcon_(routeStatus)]]"

	42 title="[[getPlayPauseTitle_(routeStatus.isPaused)]]"
	mark a. foltz 2017/05/12 00:02:46 ISTM that these helper methods should take \|routeS ISTM that these helper methods should take \|routeStatus\| consistently. takumif 2017/05/15 17:13:12 Right, there was a mismatch in the parameters and Show quoted text On 2017/05/12 00:02:46, mark a. foltz wrote: > ISTM that these helper methods should take \|routeStatus\| consistently. Right, there was a mismatch in the parameters and the arguments.
	43 on-click="onPlayPause_"></paper-icon-button>

	44 <paper-icon-button

	45 id="route-volume-button"

	46 hidden="[[!routeStatus.canMute]]"

	47 disabled="[[!routeStatus.canMute]]"

	48 icon="[[getMuteUnmuteIcon_(routeStatus)]]"

	49 title="[[getMuteUnmuteTitle_(routeStatus.isMuted)]]"

	50 on-click="onMuteUnmute_"></paper-icon-button>

	51 </span>

	52 <span id="volume-holder">

	53 <paper-slider

	54 id="route-volume-slider"

	55 hidden="[[!routeStatus.canSetVolume]]"

	56 disabled="[[!routeStatus.canSetVolume]]"

	57 on-change="onVolumeChangeComplete_"

	58 on-immediate-value-change="onVolumeChangeStart_"

	59 title="[[i18n('volumeTitle')]]"

	60 value="[[displayedVolume_]]"

	61 min="0" max="1" step="0.01"></paper-slider>

	62 </span>

	63 </div>

	64 </div>

	65 </div>

	66 </template>

	67 <script src="route_controls.js"></script>

	68 </dom-module>

OLD	NEW