chrome/browser/resources/media_router/elements/route_controls/route_controls.html - Issue 2725503002: [Media Router] Custom Controls 4 - Implement details view WebUI

Side by Side Diff: chrome/browser/resources/media_router/elements/route_controls/route_controls.html

Issue 2725503002: [Media Router] Custom Controls 4 - Implement details view WebUI (Closed)

Patch Set: Fix a test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js ('K') | « chrome/browser/resources/media_router/elements/route_controls/route_controls.css ('k') | chrome/browser/resources/media_router/elements/route_controls/route_controls.js » ('j') | chrome/browser/resources/media_router/elements/route_controls/route_controls.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/html/i18n_behavior.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/av-icons.htm l">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-slider/paper-slid er.html">

	5 <dom-module id="route-controls">

	6 <link rel="import" type="css" href="../../media_router_common.css">

	7 <link rel="import" type="css" href="route_controls.css">

	8 <template>

	9 <div id="media-controls">

	10 <div class="ellipsis" id="route-description"

	11 title="[[routeStatus_.description]]">

	12 [[routeStatus_.description]]</div>

	13 <div class="ellipsis" id="route-display-name"

	14 title="[[routeStatus_.title]]">

	15 [[routeStatus_.title]]</div>

	16 <div>

	17 <div id="route-time-controls"

	18 hidden="[[!routeStatus_.canSeek]]">

	19 <paper-slider

	20 id="route-time-slider"

	21 on-change="onTimeSliderChange_"

	22 on-immediate-value-change="onImmediateTimeSliderChange_"

	23 min="0" max="1" step="0.01"
	mark a. foltz 2017/05/03 21:26:59 Should this be in seconds reflecting the media dur Should this be in seconds reflecting the media duration, or do only the relative values matter? takumif 2017/05/05 18:57:38 Yup, doing seconds here would be a good idea. Chan Show quoted text On 2017/05/03 21:26:59, mark a. foltz wrote: > Should this be in seconds reflecting the media duration, or do only the relative > values matter? Yup, doing seconds here would be a good idea. Changed.
	24 title="[[i18n('seekTitle')]]"

	25 value="[[timeSliderValue_]]"></paper-slider>

	26 <div id="timeline">
	mark a. foltz 2017/05/03 21:26:59 Presumably, non-seekable live media can still have Presumably, non-seekable live media can still have a current_time (reflecting the lifetime of the stream) even if can_seek is false. If hiding the current_time is the existing behavior, fine to keep things this way though. takumif 2017/05/05 18:57:39 This is the existing behavior. We can change it in Show quoted text On 2017/05/03 21:26:59, mark a. foltz wrote: > Presumably, non-seekable live media can still have a current_time (reflecting > the lifetime of the stream) even if can_seek is false. > > If hiding the current_time is the existing behavior, fine to keep things this > way though. This is the existing behavior. We can change it in the future if there's a need to support non-seekable media with current_time. We'd want to show a disabled slider if it has duration too.
	27 <span id="current-time">

	28 [[getFormattedTime_(displayedCurrentTime_)]]</span>

	29 <span id="duration">[[getDuration_(routeStatus_)]]</span>

	30 </div>

	31 </div>

	32 <div id="play-pause-volume-controls">

	33 <span id="button-holder">

	34 <paper-icon-button

	35 id="route-play-pause-button"

	36 hidden="[[!routeStatus_.canPlayPause]]"

	37 disabled="[[!routeStatus_.canPlayPause]]"

	38 icon="[[getPlayPauseIcon_(routeStatus_)]]"

	39 title="[[getPlayPauseTitle_(routeStatus_.isPaused)]]"
	mark a. foltz 2017/05/03 21:26:59 Should this be i18n('play') or i18n('pause')? Can Should this be i18n('play') or i18n('pause')? Can you use a conditional expression here? takumif 2017/05/05 18:57:38 getPlayPauseTitle_() defined in route_controls.js Show quoted text On 2017/05/03 21:26:59, mark a. foltz wrote: > Should this be i18n('play') or i18n('pause')? Can you use a conditional > expression here? getPlayPauseTitle_() defined in route_controls.js returns the i18n-ized text.
	40 on-click="onPlayPause_"></paper-icon-button>

	41 <paper-icon-button

	42 id="route-volume-button"

	43 hidden="[[!routeStatus_.canMute]]"
	mark a. foltz 2017/05/03 21:26:59 disable this control as well for consistency with disable this control as well for consistency with play-pause-button takumif 2017/05/05 18:57:38 Done. Show quoted text On 2017/05/03 21:26:59, mark a. foltz wrote: > disable this control as well for consistency with play-pause-button Done.
	44 icon="[[getMuteUnmuteIcon_(routeStatus_)]]"

	45 title="[[getMuteUnmuteTitle_(routeStatus_.isMuted)]]"
	mark a. foltz 2017/05/03 21:26:59 Similar comment here Similar comment here takumif 2017/05/05 18:57:38 Same, i18n-ized text is returned by JS. Show quoted text On 2017/05/03 21:26:59, mark a. foltz wrote: > Similar comment here Same, i18n-ized text is returned by JS.
	46 on-click="onMuteUnmute_"></paper-icon-button>

	47 </span>

	48 <span id="volume-holder">

	49 <paper-slider

	50 id="route-volume-slider"

	51 hidden="[[!routeStatus_.canSetVolume]]"
	mark a. foltz 2017/05/03 21:26:59 Also disable if hidden Also disable if hidden takumif 2017/05/05 18:57:39 Done. Show quoted text On 2017/05/03 21:26:59, mark a. foltz wrote: > Also disable if hidden Done.
	52 on-change="onVolumeSliderChange_"

	53 on-immediate-value-change="onImmediateVolumeSliderChange_"

	54 title="[[i18n('volumeTitle')]]"

	55 value="[[volumeSliderValue_]]"

	56 min="0" max="1" step="0.01"></paper-slider>

	57 </span>

	58 </div>

	59 </div>

	60 </div>

	61 </template>

	62 <script src="route_controls.js"></script>

	63 </dom-module>

OLD	NEW