Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2725493002: Improve ctrl-C handling in ninja.py. (Closed)

Created:
3 years, 9 months ago by Florian Schneider
Modified:
3 years, 9 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve ctrl-C handling in ninja.py. This enables interrupting by pressing ctrl-C. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/74d2f37a86a146f28deaa0ceeadfde5f4407837c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M tools/ninja.py View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
3 years, 9 months ago (2017-02-27 23:31:02 UTC) #2
zra
lgtm
3 years, 9 months ago (2017-02-27 23:32:00 UTC) #3
Florian Schneider
3 years, 9 months ago (2017-02-27 23:38:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
74d2f37a86a146f28deaa0ceeadfde5f4407837c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698