Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 272543005: Revert "Web Animations: Timeline should not advance during task execution" (Closed)

Created:
6 years, 7 months ago by ojan
Modified:
6 years, 7 months ago
Reviewers:
dstockwell
CC:
blink-reviews, rwlbuis, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, sof, eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, blink-reviews-dom_chromium.org, darktears, Steve Block, Eric Willigers
Visibility:
Public.

Description

Revert "Web Animations: Timeline should not advance during task execution" Revert "Web Animations: Fix error in clock update logic and re-enable timeline-time test" This reverts r173583 and r173609. r173583 causes ImageResourceTest.MultipartImage to fail on Android debug, e.g., http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/152167/steps/webkit_unit_tests/logs/stdio TBR=dstockwell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -164 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/web-animations-api/element-animate-position-crash.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/web-animations-api/element-animate-position-crash-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/web-animations-api/timeline-time.html View 1 chunk +18 lines, -38 lines 0 comments Download
M Source/core/animation/AnimationClock.h View 1 chunk +18 lines, -11 lines 0 comments Download
M Source/core/animation/AnimationClock.cpp View 1 chunk +5 lines, -33 lines 0 comments Download
M Source/core/animation/AnimationClockTest.cpp View 2 chunks +23 lines, -71 lines 0 comments Download
M Source/core/animation/DocumentAnimations.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/animation/css/TransitionTimeline.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.h View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/WebKit.cpp View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 7 months ago (2014-05-08 20:11:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/272543005/1
6 years, 7 months ago (2014-05-08 20:12:11 UTC) #2
commit-bot: I haz the power
Change committed as 173685
6 years, 7 months ago (2014-05-08 21:28:16 UTC) #3
ojan
6 years, 7 months ago (2014-05-08 22:42:45 UTC) #4
Message was sent while issue was closed. 
Looks like the patch that was reverted also caused a bunch of Win Debug crashes:
https://code.google.com/p/chromium/issues/detail?id=371595.

Powered by Google App Engine
This is Rietveld 408576698