Omnibox - Cleanup From Recent Changelists

components/omnibox/browser/search_provider.cc

Index: components/omnibox/browser/search_provider.cc
diff --git a/components/omnibox/browser/search_provider.cc b/components/omnibox/browser/search_provider.cc
index 830f160e735d13350bf633ac36a4452d4c2bcf93..334508f8af1110e0c5c5b2b483b8e12ba968bb2d 100644
--- a/components/omnibox/browser/search_provider.cc
+++ b/components/omnibox/browser/search_provider.cc
@@ -271,12 +271,9 @@ void SearchProvider::Start(const AutocompleteInput& input,
   providers_.set(default_provider_keyword, keyword_provider_keyword);
 
   if (input.from_omnibox_focus()) {
-    // Don't display any suggestions for on-focus requests.  Stop any pending
-    // requests here (there likely aren't yet, though it doesn't hurt to be safe
-    // so that we can create a new request later in this flow (to warm-up the
-    // suggest server by alerting it that the user is likely about to start
-    // typing).
-    StopSuggest();
+    // Don't display any suggestions for on-focus requests.
+    DCHECK(default_fetcher_ != nullptr);
+    DCHECK(keyword_fetcher_ != nullptr);

[Peter Kasting, 2017/03/03 23:13:46]

This seems backwards.  I'd think we'd want to check that these _are_ null, not
that they're not.

But would it not be sufficient to just check |done_|?

[Mark P, 2017/03/03 23:22:25]

Heh, no wonder I just got an e-mail that the dry run failed. :-)
Yes instead.  Fixed.

     ClearAllResults();
   } else if (input.text().empty()) {
     // User typed "?" alone.  Give them a placeholder result indicating what