Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: components/ntp_tiles/icon_cacher.h

Issue 2725293002: Handle null callbacks in OnFaviconDownloaded (Closed)
Patch Set: Address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_tiles/icon_cacher_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_tiles/icon_cacher.h
diff --git a/components/ntp_tiles/icon_cacher.h b/components/ntp_tiles/icon_cacher.h
index e7456fd0a9cc9792fe856d720df2f55f6e683725..bfea2969464059c7a4e703829c4f9ad70d896f9f 100644
--- a/components/ntp_tiles/icon_cacher.h
+++ b/components/ntp_tiles/icon_cacher.h
@@ -20,10 +20,10 @@ class IconCacher {
public:
virtual ~IconCacher() = default;
- // Fetches the icon if necessary. It invokes |icon_available| if a new icon
- // was fetched. This is the only required callback.
+ // Fetches the icon if necessary. If a new icon was fetched, the optional
+ // |icon_available| callback will be invoked.
// If there are preliminary icons (e.g. provided by static resources), the
- // |preliminary_icon_available| callback will be invoked additionally.
+ // optional |preliminary_icon_available| callback will be invoked in addition.
// TODO(fhorschig): In case we keep these, make them OnceClosures.
virtual void StartFetch(PopularSites::Site site,
const base::Closure& icon_available,
« no previous file with comments | « no previous file | components/ntp_tiles/icon_cacher_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698