Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: third_party/WebKit/Source/platform/LayoutLocale.cpp

Issue 2725243003: Avoid uloc_setKeywordValue if the locale contains "@" (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/LayoutLocaleTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/LayoutLocale.cpp
diff --git a/third_party/WebKit/Source/platform/LayoutLocale.cpp b/third_party/WebKit/Source/platform/LayoutLocale.cpp
index dcda244d1eb76f581c4a706e08f70ae25af6c3ca..998e6068bbaacfb8591e6a97d8165de8af003c9f 100644
--- a/third_party/WebKit/Source/platform/LayoutLocale.cpp
+++ b/third_party/WebKit/Source/platform/LayoutLocale.cpp
@@ -189,6 +189,11 @@ AtomicString LayoutLocale::localeWithBreakKeyword(
if (m_string.isEmpty())
return m_string;
+ // uloc_setKeywordValue_58 has a problem to handle "@" in the original
+ // string. crbug.com/697859
+ if (m_string.contains('@'))
+ return m_string;
+
CString utf8Locale = m_string.utf8();
Vector<char> buffer(utf8Locale.length() + 11, 0);
memcpy(buffer.data(), utf8Locale.data(), utf8Locale.length());
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/LayoutLocaleTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698