Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: Source/core/svg/SVGElement.cpp

Issue 272523002: Remove SVGElementInstance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use attach/detach Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGElement.cpp
diff --git a/Source/core/svg/SVGElement.cpp b/Source/core/svg/SVGElement.cpp
index 7f1904c2b9d4b2db6f74236dd3ac24ed2f8dae74..f22e0885c55b9cff899f07cb13c9ceb9000f55b8 100644
--- a/Source/core/svg/SVGElement.cpp
+++ b/Source/core/svg/SVGElement.cpp
@@ -107,6 +107,20 @@ SVGElement::~SVGElement()
#endif
}
+void SVGElement::detach(const AttachContext& context)
+{
+ Element::detach(context);
+ if (correspondingElement() && correspondingElement()->instancesForElement().contains(this))
pdr. 2014/06/04 04:07:52 Can we make instancesForElement protected and move
+ correspondingElement()->removeInstanceMapping(this);
+}
+
+void SVGElement::attach(const AttachContext& context)
+{
+ Element::attach(context);
+ if (correspondingElement())
+ correspondingElement()->mapInstanceToElement(this);
+}
+
short SVGElement::tabIndex() const
{
if (supportsFocus())
@@ -1042,6 +1056,8 @@ void SVGElement::invalidateInstances()
}
}
+ svgRareData()->elementInstances().clear();
+
document().updateRenderTreeIfNeeded();
}

Powered by Google App Engine
This is Rietveld 408576698