Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: components/doodle/doodle_fetcher_impl.h

Issue 2725143003: [Doodle] Pull time_to_live out of DoodleConfig (Closed)
Patch Set: mastiz review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/doodle/doodle_fetcher.h ('k') | components/doodle/doodle_fetcher_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/doodle/doodle_fetcher_impl.h
diff --git a/components/doodle/doodle_fetcher_impl.h b/components/doodle/doodle_fetcher_impl.h
index 3f3eb19aeaa8042f8ce42b174c448f22f96fff2a..ad38992dfaab743d010b613e3e818d466effea8d 100644
--- a/components/doodle/doodle_fetcher_impl.h
+++ b/components/doodle/doodle_fetcher_impl.h
@@ -25,6 +25,7 @@ class GoogleURLTracker;
namespace base {
class DictionaryValue;
+class TimeDelta;
class Value;
}
@@ -62,18 +63,23 @@ class DoodleFetcherImpl : public DoodleFetcher, public net::URLFetcherDelegate {
// ParseJSONCallback Failure callback
void OnJsonParseFailed(const std::string& error_message);
- base::Optional<DoodleConfig> ParseDoodle(
- const base::DictionaryValue& ddljson) const;
+ base::Optional<DoodleConfig> ParseDoodleConfigAndTimeToLive(
+ const base::DictionaryValue& ddljson,
+ base::TimeDelta* time_to_live) const;
+
bool ParseImage(const base::DictionaryValue& image_dict,
const std::string& image_name,
DoodleImage* image) const;
void ParseBaseInformation(const base::DictionaryValue& ddljson,
- DoodleConfig* config) const;
+ DoodleConfig* config,
+ base::TimeDelta* time_to_live) const;
GURL ParseRelativeUrl(const base::DictionaryValue& dict_value,
const std::string& key) const;
void RespondToAllCallbacks(DoodleState state,
+ base::TimeDelta time_to_live,
const base::Optional<DoodleConfig>& config);
+
GURL GetGoogleBaseUrl() const;
// Returns whether a fetch is still in progress. A fetch begins when a
« no previous file with comments | « components/doodle/doodle_fetcher.h ('k') | components/doodle/doodle_fetcher_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698