[Doodle] Pull time_to_live out of DoodleConfig

components/doodle/doodle_fetcher.h

Index: components/doodle/doodle_fetcher.h
diff --git a/components/doodle/doodle_fetcher.h b/components/doodle/doodle_fetcher.h
index f5ef780410ce5094f66e2a91b7a1ee866864035c..e7a5d2636b9243c07533f81cf6a05988f5103e45 100644
--- a/components/doodle/doodle_fetcher.h
+++ b/components/doodle/doodle_fetcher.h
@@ -9,6 +9,10 @@
 #include "base/optional.h"
 #include "components/doodle/doodle_types.h"
 
+namespace base {
+class TimeDelta;
+}
+
 namespace doodle {
 
 // Interface for fetching the current doodle from the network.
@@ -19,9 +23,11 @@ namespace doodle {
 class DoodleFetcher {
  public:
   // Callback that is invoked when the fetching is done.
-  // |doodle_config| will only contain a value if |state| is AVAILABLE.
+  // |time_to_live| will only be meaningful, and |doodle_config| will only
+  // contain a value, if |state| is AVAILABLE.
   using FinishedCallback = base::OnceCallback<void(
       DoodleState state,
+      base::TimeDelta time_to_live,
       const base::Optional<DoodleConfig>& doodle_config)>;

[Marc Treib, 2017/03/02 11:42:51]

As an alternative, we could wrap ttl and config into a new "DoodleResponse", but
that seems more trouble than it's worth. WDYT?

[fhorschig, 2017/03/02 13:18:08]

Doesn't sound too bad but I think for three parameters,
this solution is good.

 
   virtual ~DoodleFetcher() = default;