Mojo: Armed Watchers

content/child/url_response_body_consumer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/url_response_body_consumer.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
@@ skipping 30 matching lines @@
 };
 
 URLResponseBodyConsumer::URLResponseBodyConsumer(
     int request_id,
     ResourceDispatcher* resource_dispatcher,
     mojo::ScopedDataPipeConsumerHandle handle,
     scoped_refptr<base::SingleThreadTaskRunner> task_runner)
     : request_id_(request_id),
       resource_dispatcher_(resource_dispatcher),
       handle_(std::move(handle)),
-      handle_watcher_(FROM_HERE, task_runner),
+      handle_watcher_(FROM_HERE,
+                      mojo::Watcher::ArmingPolicy::AUTOMATIC,
+                      task_runner),
       task_runner_(task_runner),
       has_seen_end_of_data_(!handle_.is_valid()) {
   handle_watcher_.Start(
       handle_.get(), MOJO_HANDLE_SIGNAL_READABLE,
       base::Bind(&URLResponseBodyConsumer::OnReadable, base::Unretained(this)));
   task_runner_->PostTask(
       FROM_HERE, base::Bind(&URLResponseBodyConsumer::OnReadable, AsWeakPtr(),

[yzshen1, 2017/03/11 00:44:58]

We may not need weak ptr support for this class any more.

[Ken Rockot(use gerrit already), 2017/03/12 22:24:13]

I think that's true, but I'd rather leave this unchanged for this CL if you're
OK with that

                             MOJO_RESULT_OK));
 }
 
 URLResponseBodyConsumer::~URLResponseBodyConsumer() {}
 
 void URLResponseBodyConsumer::OnComplete(
     const ResourceRequestCompletionStatus& status) {
   if (has_been_cancelled_)
     return;
   has_received_completion_ = true;
@@ skipping 96 matching lines @@
     return;
   // Cancel this instance in order not to notify twice.
   Cancel();
 
   resource_dispatcher_->DispatchMessage(
       ResourceMsg_RequestComplete(request_id_, completion_status_));
   // |this| may be deleted.
 }
 
 }  // namespace content