Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 272513004: Reland r20974: Unify and simplify the FastCloneShallowArrayStub (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: This time it will work! Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "v8.h" 5 #include "v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1787 matching lines...) Expand 10 before | Expand all | Expand 10 after
1798 // If the only customer of allocation sites is transitioning, then 1798 // If the only customer of allocation sites is transitioning, then
1799 // we can turn it off if we don't have anywhere else to transition to. 1799 // we can turn it off if we don't have anywhere else to transition to.
1800 allocation_site_mode = DONT_TRACK_ALLOCATION_SITE; 1800 allocation_site_mode = DONT_TRACK_ALLOCATION_SITE;
1801 } 1801 }
1802 1802
1803 __ mov(a0, result_register()); 1803 __ mov(a0, result_register());
1804 __ lw(a3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 1804 __ lw(a3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
1805 __ lw(a3, FieldMemOperand(a3, JSFunction::kLiteralsOffset)); 1805 __ lw(a3, FieldMemOperand(a3, JSFunction::kLiteralsOffset));
1806 __ li(a2, Operand(Smi::FromInt(expr->literal_index()))); 1806 __ li(a2, Operand(Smi::FromInt(expr->literal_index())));
1807 __ li(a1, Operand(constant_elements)); 1807 __ li(a1, Operand(constant_elements));
1808 if (has_fast_elements && constant_elements_values->map() == 1808 if (expr->depth() > 1) {
1809 isolate()->heap()->fixed_cow_array_map()) {
1810 FastCloneShallowArrayStub stub(
1811 isolate(),
1812 FastCloneShallowArrayStub::COPY_ON_WRITE_ELEMENTS,
1813 allocation_site_mode,
1814 length);
1815 __ CallStub(&stub);
1816 __ IncrementCounter(isolate()->counters()->cow_arrays_created_stub(),
1817 1, a1, a2);
1818 } else if (expr->depth() > 1 || Serializer::enabled(isolate()) ||
1819 length > FastCloneShallowArrayStub::kMaximumClonedLength) {
1820 __ li(a0, Operand(Smi::FromInt(flags))); 1809 __ li(a0, Operand(Smi::FromInt(flags)));
1821 __ Push(a3, a2, a1, a0); 1810 __ Push(a3, a2, a1, a0);
1822 __ CallRuntime(Runtime::kHiddenCreateArrayLiteral, 4); 1811 __ CallRuntime(Runtime::kHiddenCreateArrayLiteral, 4);
1823 } else { 1812 } else {
1824 ASSERT(IsFastSmiOrObjectElementsKind(constant_elements_kind) || 1813 FastCloneShallowArrayStub stub(isolate(), allocation_site_mode);
1825 FLAG_smi_only_arrays);
1826 FastCloneShallowArrayStub::Mode mode =
1827 FastCloneShallowArrayStub::CLONE_ANY_ELEMENTS;
1828
1829 if (has_fast_elements) {
1830 mode = FastCloneShallowArrayStub::CLONE_ELEMENTS;
1831 }
1832
1833 FastCloneShallowArrayStub stub(isolate(), mode, allocation_site_mode,
1834 length);
1835 __ CallStub(&stub); 1814 __ CallStub(&stub);
1836 } 1815 }
1837 1816
1838 bool result_saved = false; // Is the result saved to the stack? 1817 bool result_saved = false; // Is the result saved to the stack?
1839 1818
1840 // Emit code to evaluate all the non-constant subexpressions and to store 1819 // Emit code to evaluate all the non-constant subexpressions and to store
1841 // them into the newly cloned array. 1820 // them into the newly cloned array.
1842 for (int i = 0; i < length; i++) { 1821 for (int i = 0; i < length; i++) {
1843 Expression* subexpr = subexprs->at(i); 1822 Expression* subexpr = subexprs->at(i);
1844 // If the subexpression is a literal or a simple materialized literal it 1823 // If the subexpression is a literal or a simple materialized literal it
(...skipping 3028 matching lines...) Expand 10 before | Expand all | Expand 10 after
4873 Assembler::target_address_at(pc_immediate_load_address)) == 4852 Assembler::target_address_at(pc_immediate_load_address)) ==
4874 reinterpret_cast<uint32_t>( 4853 reinterpret_cast<uint32_t>(
4875 isolate->builtins()->OsrAfterStackCheck()->entry())); 4854 isolate->builtins()->OsrAfterStackCheck()->entry()));
4876 return OSR_AFTER_STACK_CHECK; 4855 return OSR_AFTER_STACK_CHECK;
4877 } 4856 }
4878 4857
4879 4858
4880 } } // namespace v8::internal 4859 } } // namespace v8::internal
4881 4860
4882 #endif // V8_TARGET_ARCH_MIPS 4861 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« src/hydrogen.cc ('K') | « src/mips/code-stubs-mips.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698