third_party/WebKit/Source/core/css/FontFaceSet.cpp - Issue 2725063003: Migrate WTF::LinkedHashSet/ListHashSet/HashTable::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/FontFaceSet.cpp

Issue 2725063003: Migrate WTF::LinkedHashSet/ListHashSet/HashTable::remove() to ::erase() (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/FontFaceSet.cpp

diff --git a/third_party/WebKit/Source/core/css/FontFaceSet.cpp b/third_party/WebKit/Source/core/css/FontFaceSet.cpp

index 46edb57de7f6c781cf715999782a5a0f969e92c7..34fab213ee13c88c5b703f7c1446c251d6f8bf2d 100644

--- a/third_party/WebKit/Source/core/css/FontFaceSet.cpp

+++ b/third_party/WebKit/Source/core/css/FontFaceSet.cpp

@@ -296,7 +296,7 @@ bool FontFaceSet::deleteForBinding(ScriptState*,

HeapListHashSet<Member<FontFace>>::iterator it =

m_nonCSSConnectedFaces.find(fontFace);

if (it != m_nonCSSConnectedFaces.end()) {

- m_nonCSSConnectedFaces.remove(it);

+ m_nonCSSConnectedFaces.erase(it);

CSSFontSelector* fontSelector = document()->styleEngine().fontSelector();

fontSelector->fontFaceCache()->removeFontFace(fontFace, false);

if (fontFace->loadStatus() == FontFace::Loading)