store map ptr in GrGeometryBuffer base class

store map ptr in GrGeometryBuffer base class

Committed: http://code.google.com/p/skia/source/detail?r=14652

[bsalomon, 2014-05-08 15:08:45]

Makes the isMapped() and mappedPtr() functions completely non-virtual. Converts
the others to the foo(), virtual onFoo() pattern.

[robertphillips, 2014-05-08 15:25:46]

lgtm + questions

https://codereview.chromium.org/272503009/diff/20001/src/gpu/GrGeometryBuffer.h
File src/gpu/GrGeometryBuffer.h (right):

https://codereview.chromium.org/272503009/diff/20001/src/gpu/GrGeometryBuffer...
src/gpu/GrGeometryBuffer.h:60: void unmap() {
== -> != ?

https://codereview.chromium.org/272503009/diff/20001/src/gpu/gl/GrGLIndexBuff...
File src/gpu/gl/GrGLIndexBuffer.cpp (left):

https://codereview.chromium.org/272503009/diff/20001/src/gpu/gl/GrGLIndexBuff...
src/gpu/gl/GrGLIndexBuffer.cpp:37: void* GrGLIndexBuffer::mapPtr() const {
Does fImpl require a mapPtr entry point anymore?

https://codereview.chromium.org/272503009/diff/20001/src/gpu/gl/GrGLVertexBuf...
File src/gpu/gl/GrGLVertexBuffer.cpp (right):

https://codereview.chromium.org/272503009/diff/20001/src/gpu/gl/GrGLVertexBuf...
src/gpu/gl/GrGLVertexBuffer.cpp:38: if (!this->wasDestroyed()) {
Do we need this return?

[bsalomon, 2014-05-08 17:02:48]

https://codereview.chromium.org/272503009/diff/20001/src/gpu/GrGeometryBuffer.h
File src/gpu/GrGeometryBuffer.h (right):

https://codereview.chromium.org/272503009/diff/20001/src/gpu/GrGeometryBuffer...
src/gpu/GrGeometryBuffer.h:60: void unmap() {
On 2014/05/08 15:25:46, robertphillips wrote:
> == -> != ?

duh, done.

https://codereview.chromium.org/272503009/diff/20001/src/gpu/gl/GrGLIndexBuff...
File src/gpu/gl/GrGLIndexBuffer.cpp (left):

https://codereview.chromium.org/272503009/diff/20001/src/gpu/gl/GrGLIndexBuff...
src/gpu/gl/GrGLIndexBuffer.cpp:37: void* GrGLIndexBuffer::mapPtr() const {
On 2014/05/08 15:25:46, robertphillips wrote:
> Does fImpl require a mapPtr entry point anymore?

Done.

https://codereview.chromium.org/272503009/diff/20001/src/gpu/gl/GrGLVertexBuf...
File src/gpu/gl/GrGLVertexBuffer.cpp (right):

https://codereview.chromium.org/272503009/diff/20001/src/gpu/gl/GrGLVertexBuf...
src/gpu/gl/GrGLVertexBuffer.cpp:38: if (!this->wasDestroyed()) {
On 2014/05/08 15:25:46, robertphillips wrote:
> Do we need this return?

nope, i had this function as a bool and then decided against it.

[bsalomon, 2014-05-08 17:02:51]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-05-08 17:04:06]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/272503009/40001

[commit-bot: I haz the power, 2014-05-08 18:13:27]

Change committed as 14652