Wire up chrome field trials with webrtc.

Wire up chrome field trials with webrtc.

BUG=367114
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270994

[andresp-chromium, 2014-05-07 12:28:08]

This should be the only change needed in chrome to have webrtc query chrome
field trials directly.

Note this depends on http://review.webrtc.org/14399004/ being submitted and
imported on chrome. Just wanted to get feedback as early as possible.

Tommi, if you have time can you also review the webrtc one?
Magnus seems to be quite busy this week.

[andresp-chromium, 2014-05-07 12:28:38]

+cc(mflodman)

[tommi (sloooow) - chröme, 2014-05-07 12:49:32]

https://codereview.chromium.org/272503004/diff/1/content/renderer/media/media...
File content/renderer/media/media_stream_dependency_factory.cc (right):

https://codereview.chromium.org/272503004/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_dependency_factory.cc:275:
webrtc::FieldTrial::Init(&base::FieldTrialList::FindFullName);
Would InitializeWebRtcModule be a better place to call this function?
It gets called much earlier and at a more reliable point in time.

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

[andresp-chromium, 2014-05-09 10:53:53]

Updated for the webrtc::field_trials version submitted today for webrtc in
rev6089

Note that I am yet to find how to run a try job that uses a webrtc change that
access the field trial and crashes if not set so I can be sure I have updated
all need places that load webrtc in chrome.

Also note that I can't submit this yet until the webrtc version has been
imported in chrome.

[Ronghua Wu (Left Chromium), 2014-05-09 20:37:58]

This is cool. LGTM but I don't know this well enough as Tommi/Alexei. So I will
leave it to them.

[Alexei Svitkine (slow), 2014-05-09 21:07:13]

lgtm, but I'm not familiar with webrtc init code in general, so would be good
for someone familiar with that to have a look

[tommi (sloooow) - chröme, 2014-05-10 07:26:21]

Lgtm % nit

https://codereview.chromium.org/272503004/diff/40001/third_party/libjingle/ov...
File third_party/libjingle/overrides/init_webrtc.h (right):

https://codereview.chromium.org/272503004/diff/40001/third_party/libjingle/ov...
third_party/libjingle/overrides/init_webrtc.h:53:
webrtc::field_trial::FindFullNameMethod field_trial_find,
Can we pass as pointer like we do for the other methods?

[andresp-chromium, 2014-05-13 12:23:12]

Plan on how to wire has changed:

 - webrtc clients will have the ability to implement
webrtc::field_trial::FindFullName or link with
system_wrappers/source/system_wrappers.gyp:field_trial_default
 - chrome will opt to provide its own implementation for static linking defined
in libjingle/override/init_webrtc.cc, for dynamic link defined in
libjingle/override/initialize_module.cc


TESTED=compile both chromium and chrome with and without
GYP_DEFINES=component=shared_library and verified that activated field trials
were passed into a modified version of webrtc that was querying them.

[tommi (sloooow) - chröme, 2014-05-13 14:46:48]

lgtm

[andresp-chromium, 2014-05-15 09:51:40]

The CQ bit was checked by andresp@chromium.org

[commit-bot: I haz the power, 2014-05-15 09:52:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/andresp@chromium.org/272503004/60001

[commit-bot: I haz the power, 2014-05-15 13:22:13]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[andresp-chromium, 2014-05-15 13:37:22]

The CQ bit was unchecked by andresp@chromium.org

[commit-bot: I haz the power, 2014-05-15 13:37:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-15 13:37:54]

Try jobs failed on following builders:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)

[andresp-chromium, 2014-05-15 13:38:11]

On 2014/05/15 13:22:13, I haz the power (commit-bot) wrote:
> FYI, CQ is re-trying this CL (attempt #1).
> Please consider checking whether the failures are real,
> and report flakes to mailto:chrome-troopers@google.com.
> The failing builders are:
>   android_clang_dbg on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
>   android_dbg on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
>   linux_chromium_chromeos_clang_dbg on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
>   linux_chromium_clang_dbg on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
>   win_chromium_compile_dbg on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

It seems the bots have not yet pick the latest rolled webrtc. Will try again
tomorrow.

[andresp-chromium, 2014-05-16 08:26:40]

The CQ bit was checked by andresp@chromium.org

[commit-bot: I haz the power, 2014-05-16 08:27:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/andresp@chromium.org/272503004/60001

[commit-bot: I haz the power, 2014-05-16 09:46:30]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)

[commit-bot: I haz the power, 2014-05-16 11:01:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 11:01:04]

Failed to apply patch for
@master/third_party/libjingle/overrides/init_webrtc.cc:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  svn: '@master' is just a peg revision. Maybe try '@master@' instead?

Patch:       @master/third_party/libjingle/overrides/init_webrtc.cc
Index: third_party/libjingle/overrides/init_webrtc.cc
diff --git @master/third_party/libjingle/overrides/init_webrtc.cc
@master/third_party/libjingle/overrides/init_webrtc.cc
index
eda9858f8c9b166bada6f4f95f94fbb2408457b3..5c356ab89f72fdc55e4fed5e0d544e0f0b7a069c
100644
--- a/@master/third_party/libjingle/overrides/init_webrtc.cc
+++ b/@master/third_party/libjingle/overrides/init_webrtc.cc
@@ -8,6 +8,7 @@
 #include "base/debug/trace_event.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
+#include "base/metrics/field_trial.h"
 #include "base/native_library.h"
 #include "base/path_service.h"
 #include "talk/base/basictypes.h"
@@ -42,6 +43,17 @@ bool InitializeWebRtcModule() {
   return true;
 }
 
+// Define webrtc:field_trial::FindFullName to provide webrtc with a field trial
+// implementation. When compiled as a static library this can be done directly
+// and without pointers to functions.
+namespace webrtc {
+namespace field_trial {
+std::string FindFullName(const std::string& trial_name) {
+  return base::FieldTrialList::FindFullName(trial_name);
+}
+}  // namespace field_trial
+}  // namespace webrtc
+
 #else  // !LIBPEERCONNECTION_LIB
 
 // When being compiled as a shared library, we need to bridge the gap between
@@ -117,6 +129,7 @@ bool InitializeWebRtcModule() {
 #if !defined(OS_MACOSX) && !defined(OS_ANDROID)
       &Allocate, &Dellocate,
 #endif
+      &base::FieldTrialList::FindFullName,
       logging::GetLogMessageHandler(),
       &GetCategoryGroupEnabled, &AddTraceEvent,
       &g_create_webrtc_media_engine, &g_destroy_webrtc_media_engine,

[Paweł Hajdan Jr., 2014-05-16 11:47:58]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-05-16 11:48:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/andresp@chromium.org/272503004/60001

[commit-bot: I haz the power, 2014-05-16 11:49:11]

Change committed as 270994