Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2725003003: Enable LayoutNGInline in LayoutNG virtual test suite. (Closed)

Created:
3 years, 9 months ago by Gleb Lanbin
Modified:
3 years, 9 months ago
Reviewers:
ikilpatrick, kojii
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable LayoutNGInline in LayoutNG virtual test suite. BUG=635619 Review-Url: https://codereview.chromium.org/2725003003 Cr-Commit-Position: refs/heads/master@{#454442} Committed: https://chromium.googlesource.com/chromium/src/+/55fe0730698fe3a8c88756055c9746a4b6984a7c

Patch Set 1 #

Patch Set 2 : update TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -174 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 18 chunks +60 lines, -170 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Gleb Lanbin
3 years, 9 months ago (2017-03-02 19:15:25 UTC) #2
ikilpatrick
lgtm, I assume kojii is fine with this :)
3 years, 9 months ago (2017-03-02 19:18:07 UTC) #3
Gleb Lanbin
+kojii@ I think so. The "margin collapsing+inline" and "line height" were the last major known ...
3 years, 9 months ago (2017-03-02 19:37:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725003003/20001
3 years, 9 months ago (2017-03-02 23:29:38 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/55fe0730698fe3a8c88756055c9746a4b6984a7c
3 years, 9 months ago (2017-03-03 00:01:02 UTC) #17
kojii
3 years, 9 months ago (2017-03-03 07:37:59 UTC) #18
Message was sent while issue was closed.
lgtm, thank you for doing this. I wanted to do this but slow to review all
failures, this is really appreciated!

Powered by Google App Engine
This is Rietveld 408576698