Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: components/exo/compositor_frame_sink_holder.h

Issue 2724953007: [exo] Clean up BeginFrame distribution & add acks in Surface. (Closed)
Patch Set: rename instance var. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/exo/BUILD.gn ('k') | components/exo/compositor_frame_sink_holder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/exo/compositor_frame_sink_holder.h
diff --git a/components/exo/compositor_frame_sink_holder.h b/components/exo/compositor_frame_sink_holder.h
index 4f3b0a21d89bc936b4cfcc56b1d205f4703b3079..0ba280ef67f15e7ac2c05465a1ac4e6976121852 100644
--- a/components/exo/compositor_frame_sink_holder.h
+++ b/components/exo/compositor_frame_sink_holder.h
@@ -28,7 +28,6 @@ class CompositorFrameSinkHolder
: public base::RefCounted<CompositorFrameSinkHolder>,
public cc::ExternalBeginFrameSourceClient,
public cc::mojom::MojoCompositorFrameSinkClient,
- public cc::BeginFrameObserver,
public SurfaceObserver {
public:
CompositorFrameSinkHolder(Surface* surface,
@@ -45,8 +44,6 @@ class CompositorFrameSinkHolder
return weak_factory_.GetWeakPtr();
}
- void SetNeedsBeginFrame(bool needs_begin_frame);
-
// Overridden from cc::mojom::MojoCompositorFrameSinkClient:
void DidReceiveCompositorFrameAck() override;
void OnBeginFrame(const cc::BeginFrameArgs& args) override;
@@ -54,10 +51,6 @@ class CompositorFrameSinkHolder
void WillDrawSurface(const cc::LocalSurfaceId& local_surface_id,
const gfx::Rect& damage_rect) override;
- // Overridden from cc::BeginFrameObserver:
- const cc::BeginFrameArgs& LastUsedBeginFrameArgs() const override;
- void OnBeginFrameSourcePausedChanged(bool paused) override;
-
// Overridden from cc::ExternalBeginFrameSourceClient:
void OnNeedsBeginFrames(bool needs_begin_frames) override;
void OnDidFinishFrame(const cc::BeginFrameAck& ack) override;
@@ -70,18 +63,13 @@ class CompositorFrameSinkHolder
~CompositorFrameSinkHolder() override;
- void UpdateNeedsBeginFrame();
-
// A collection of callbacks used to release resources.
using ResourceReleaseCallbackMap = std::map<int, cc::ReleaseCallback>;
ResourceReleaseCallbackMap release_callbacks_;
Surface* surface_;
std::unique_ptr<CompositorFrameSink> frame_sink_;
-
std::unique_ptr<cc::ExternalBeginFrameSource> begin_frame_source_;
- bool needs_begin_frame_ = false;
- cc::BeginFrameArgs last_begin_frame_args_;
base::WeakPtrFactory<CompositorFrameSinkHolder> weak_factory_;
« no previous file with comments | « components/exo/BUILD.gn ('k') | components/exo/compositor_frame_sink_holder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698