extensions/renderer/mojo/frame_observer.mojom - Issue 2724933002: Convert SetVisuallyDeemphasized IPC to mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/renderer/mojo/frame_observer.mojom

Issue 2724933002: Convert SetVisuallyDeemphasized IPC to mojo (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module extensions.mojom;

	6

	7 interface FrameObserver {
	Devlin 2017/03/04 02:19:41 This isn't really a FrameObserver, per se (beyond This isn't really a FrameObserver, per se (beyond the fact that the renderer-side binding for it hangs off a RenderFrameObserver). Since this message is for app windows, maybe something like AppWindowHandler, or similar? catmullings 2017/03/06 21:20:40 Done. Show quoted text On 2017/03/04 02:19:41, Devlin wrote: > This isn't really a FrameObserver, per se (beyond the fact that the > renderer-side binding for it hangs off a RenderFrameObserver). Since this > message is for app windows, maybe something like AppWindowHandler, or similar? Done.
	8 SetVisuallyDeemphasized(bool deemphasized);
	Devlin 2017/03/04 02:19:41 Since this is a shared topic between browser and r Since this is a shared topic between browser and renderer, we should put it in extensions/common (similarly to how the previous message was in chrome/common). That will solve the layering violations. :) catmullings 2017/03/06 21:20:40 Done. Show quoted text On 2017/03/04 02:19:41, Devlin wrote: > Since this is a shared topic between browser and renderer, we should put it in > extensions/common (similarly to how the previous message was in chrome/common). > That will solve the layering violations. :) Done.
	9 };

OLD	NEW

« extensions/renderer/extensions_render_frame_observer.h ('K') | « extensions/renderer/extensions_render_frame_observer.cc ('k') | no next file » | no next file with comments »