Force chooser bubbles to close synchronously.

chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 64 matching lines @@
   DeviceChooserContentView* device_chooser_content_view_;
   BubbleReference bubble_reference_;
 
   DISALLOW_COPY_AND_ASSIGN(ChooserBubbleUiViewDelegate);
 };
 
 ChooserBubbleUiViewDelegate::ChooserBubbleUiViewDelegate(
     views::View* anchor_view,
     views::BubbleBorder::Arrow anchor_arrow,
     std::unique_ptr<ChooserController> chooser_controller)
-    : views::BubbleDialogDelegateView(anchor_view, anchor_arrow),
-      device_chooser_content_view_(nullptr) {
+    : views::BubbleDialogDelegateView(anchor_view, anchor_arrow) {
   // ------------------------------------
   // | Chooser bubble title             |
   // | -------------------------------- |
   // | | option 0                     | |
   // | | option 1                     | |
   // | | option 2                     | |
   // | |                              | |
   // | |                              | |
   // | |                              | |
   // | -------------------------------- |
@@ skipping 81 matching lines @@
 
 void ChooserBubbleUiViewDelegate::UpdateTableView() const {
   device_chooser_content_view_->UpdateTableView();
 }
 
 //////////////////////////////////////////////////////////////////////////////
 // ChooserBubbleUiView
 ChooserBubbleUiView::ChooserBubbleUiView(
     Browser* browser,
     std::unique_ptr<ChooserController> chooser_controller)
-    : browser_(browser), chooser_bubble_ui_view_delegate_(nullptr) {
+    : browser_(browser) {
   DCHECK(browser_);
   DCHECK(chooser_controller);
-  chooser_bubble_ui_view_delegate_ = new ChooserBubbleUiViewDelegate(
+  bubble_view_ = new ChooserBubbleUiViewDelegate(
       GetAnchorView(), GetAnchorArrow(), std::move(chooser_controller));
 }
 
 ChooserBubbleUiView::~ChooserBubbleUiView() {}
 
 void ChooserBubbleUiView::Show(BubbleReference bubble_reference) {
-  chooser_bubble_ui_view_delegate_->set_bubble_reference(bubble_reference);
+  bubble_view_->set_bubble_reference(bubble_reference);
 
   // Set |parent_window| because some valid anchors can become hidden.
   views::Widget* widget = views::Widget::GetWidgetForNativeWindow(
       browser_->window()->GetNativeWindow());
-  chooser_bubble_ui_view_delegate_->set_parent_window(widget->GetNativeView());
+  bubble_view_->set_parent_window(widget->GetNativeView());
 
-  views::BubbleDialogDelegateView::CreateBubble(
-      chooser_bubble_ui_view_delegate_)
-      ->Show();
-
-  chooser_bubble_ui_view_delegate_->UpdateTableView();
+  views::BubbleDialogDelegateView::CreateBubble(bubble_view_)->Show();
+  bubble_view_->GetWidget()->AddObserver(this);
+  bubble_view_->UpdateTableView();
 }
 
-void ChooserBubbleUiView::Close() {}
+void ChooserBubbleUiView::Close() {
+  if (bubble_view_ && !bubble_view_->GetWidget()->IsClosed()) {
+    // The widget hierarchy must be destroyed synchronously by using CloseNow
+    // because the ChooserController may hold a raw pointer to the
+    // RenderFrameHost. See https://crbug.com/697486 for an example.
+    bubble_view_->GetWidget()->CloseNow();
+  }
+}
 
 void ChooserBubbleUiView::UpdateAnchorPosition() {
-  chooser_bubble_ui_view_delegate_->UpdateAnchor(GetAnchorView(),
-                                                 GetAnchorArrow());
+  DCHECK(bubble_view_);
+  bubble_view_->UpdateAnchor(GetAnchorView(), GetAnchorArrow());
+}
+
+void ChooserBubbleUiView::OnWidgetClosing(views::Widget* widget) {
+  DCHECK_EQ(bubble_view_->GetWidget(), widget);
+  widget->RemoveObserver(this);
+  bubble_view_ = nullptr;
 }
 
 views::View* ChooserBubbleUiView::GetAnchorView() {
   BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser_);
 
   if (browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR))
     return browser_view->GetLocationBarView()
         ->location_icon_view()
         ->GetImageView();
 
   if (browser_view->IsFullscreenBubbleVisible())
     return browser_view->exclusive_access_bubble()->GetView();
 
   return browser_view->top_container();
 }
 
 views::BubbleBorder::Arrow ChooserBubbleUiView::GetAnchorArrow() {
   if (browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR))
     return views::BubbleBorder::TOP_LEFT;
   return views::BubbleBorder::NONE;
 }