Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: src/debug/debug-evaluate.cc

Issue 2724833002: Migrate Object.prototype.valueOf to CSA (Closed)
Patch Set: Separate CL & fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/debug-evaluate.cc
diff --git a/src/debug/debug-evaluate.cc b/src/debug/debug-evaluate.cc
index c6fafa557b7da20e706578f89ee89b5cc8ef5eef..c709d0da3e3a0e492197dcfeff4dc5fc15e97bd2 100644
--- a/src/debug/debug-evaluate.cc
+++ b/src/debug/debug-evaluate.cc
@@ -261,7 +261,7 @@ namespace {
bool IntrinsicHasNoSideEffect(Runtime::FunctionId id) {
switch (id) {
- // Whitelist for intrinsics amd runtime functions.
+ // Whitelist for intrinsics and runtime functions.
// Conversions.
case Runtime::kToInteger:
case Runtime::kInlineToInteger:
@@ -405,6 +405,8 @@ bool BytecodeHasNoSideEffect(interpreter::Bytecode bytecode) {
bool BuiltinHasNoSideEffect(Builtins::Name id) {
switch (id) {
// Whitelist for builtins.
+ // Object builtins.
+ case Builtins::kObjectPrototypeValueOf:
// Array builtins.
case Builtins::kArrayCode:
case Builtins::kArrayIndexOf:
« src/bootstrapper.cc ('K') | « src/builtins/builtins-object.cc ('k') | src/js/v8natives.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698