Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: src/js/v8natives.js

Issue 2724833002: Migrate Object.prototype.valueOf to CSA (Closed)
Patch Set: Add set_object_value & update cctest Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/js/v8natives.js
diff --git a/src/js/v8natives.js b/src/js/v8natives.js
index 29f9c45efa854360c259e620da1209d0a511e372..60a78d0ca986d52be9628a1b6a54880d3ddc7017 100644
--- a/src/js/v8natives.js
+++ b/src/js/v8natives.js
@@ -11,7 +11,6 @@
var GlobalObject = global.Object;
var iteratorSymbol = utils.ImportNow("iterator_symbol");
-var NaN = %GetRootNaN();
Yang 2017/03/02 06:55:12 Do we still need the runtime function for this too
rongjie 2017/03/02 07:29:15 I forgot to remove this in https://codereview.chro
var ObjectToString = utils.ImportNow("object_to_string");
// ----------------------------------------------------------------------------
@@ -31,12 +30,6 @@ function ObjectToLocaleString() {
}
-// ES6 19.1.3.7 Object.prototype.valueOf()
-function ObjectValueOf() {
- return TO_OBJECT(this);
-}
-
-
// ES6 19.1.3.3 Object.prototype.isPrototypeOf(V)
function ObjectIsPrototypeOf(V) {
if (!IS_RECEIVER(V)) return false;
@@ -76,7 +69,7 @@ function ObjectConstructor(x) {
utils.InstallFunctions(GlobalObject.prototype, DONT_ENUM, [
"toString", ObjectToString,
"toLocaleString", ObjectToLocaleString,
- "valueOf", ObjectValueOf,
+ // valueOf is added in bootstrapper.cc.
"isPrototypeOf", ObjectIsPrototypeOf,
// propertyIsEnumerable is added in bootstrapper.cc.
// __defineGetter__ is added in bootstrapper.cc.
@@ -113,8 +106,4 @@ utils.Export(function(to) {
to.ObjectHasOwnProperty = GlobalObject.prototype.hasOwnProperty;
});
-%InstallToContext([
- "object_value_of", ObjectValueOf,
-]);
-
})

Powered by Google App Engine
This is Rietveld 408576698