content/browser/background_fetch/background_fetch_data_manager_unittest.cc - Issue 2724783002: Make the BackgroundFetchJobController a per-job object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_fetch/background_fetch_data_manager_unittest.cc

Issue 2724783002: Make the BackgroundFetchJobController a per-job object (Closed)

Patch Set: Fixed destructor threading and nits Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/background_fetch/background_fetch_data_manager.h ('K') | « content/browser/background_fetch/background_fetch_data_manager.cc ('k') | content/browser/background_fetch/background_fetch_job_controller.h » ('j') | content/browser/background_fetch/background_fetch_job_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_fetch/background_fetch_data_manager_unittest.cc

diff --git a/content/browser/background_fetch/background_fetch_data_manager_unittest.cc b/content/browser/background_fetch/background_fetch_data_manager_unittest.cc

index 17f37e584eb6c6115bbd1f958f46248bb4a931f9..031aabdc129b37718b972868f3969089971ac68c 100644

--- a/content/browser/background_fetch/background_fetch_data_manager_unittest.cc

+++ b/content/browser/background_fetch/background_fetch_data_manager_unittest.cc

@@ -60,7 +60,7 @@ TEST_F(BackgroundFetchDataManagerTest, AddRequest) {

// Initialize a BackgroundFetchJobData with the constructed requests.

BackgroundFetchDataManager* data_manager = GetDataManager();

- BackgroundFetchJobData* job_data =

+ std::unique_ptr<BackgroundFetchJobData> job_data =

data_manager->CreateRequest(job_info, request_infos);

// Get all of the fetch requests from the BackgroundFetchJobData.