Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1531)

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 2724723002: [WebAPKs]: Reduce the parameters of ShortcutHelper::AddToLauncherWithSkBitmap() (Closed)
Patch Set: Merge branch 'master' into refactor_shortcut_helper2 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/shortcut_helper.h
diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h
index 7a30fd3f0f8bdf2f15ef6fbd464371c70aed0343..d352f9708ff50ab839e44f148b38739ceb21937f 100644
--- a/chrome/browser/android/shortcut_helper.h
+++ b/chrome/browser/android/shortcut_helper.h
@@ -18,9 +18,8 @@
#include "third_party/skia/include/core/SkBitmap.h"
namespace content {
-class BrowserContext;
class WebContents;
-} // namespace content
+}
// ShortcutHelper is the C++ counterpart of org.chromium.chrome.browser's
// ShortcutHelper in Java.
@@ -36,16 +35,13 @@ class ShortcutHelper {
// added depends on the properties in |info|. Calls one of
// InstallWebApkInBackgroundWithSkBitmap, AddWebappInBackgroundWithSkBitmap,
// or AddShortcutInBackgroundWithSkBitmap.
- static void AddToLauncherWithSkBitmap(
- content::BrowserContext* browser_context,
- const ShortcutInfo& info,
- const std::string& webapp_id,
- const SkBitmap& icon_bitmap,
- const base::Closure& splash_image_callback);
+ static void AddToLauncherWithSkBitmap(content::WebContents* web_contents,
+ const ShortcutInfo& info,
+ const SkBitmap& icon_bitmap);
// Installs WebAPK and adds shortcut to the launcher.
static void InstallWebApkWithSkBitmap(
- content::BrowserContext* browser_context,
+ content::WebContents* web_conetnts,
const ShortcutInfo& info,
const SkBitmap& icon_bitmap,
const WebApkInstaller::FinishCallback& callback);
« no previous file with comments | « chrome/browser/android/banners/app_banner_manager_android.cc ('k') | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698