[WebAPKs]: Reduce the parameters of ShortcutHelper::AddToLauncherWithSkBitmap()

chrome/browser/android/shortcut_helper.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_
 #define CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 18 matching lines @@
   using WebApkInfoCallback =
       base::Callback<void(const std::vector<WebApkInfo>&)>;
 
   // Registers JNI hooks.
   static bool RegisterShortcutHelper(JNIEnv* env);
 
   // Adds a shortcut to the launcher using a SkBitmap. The type of shortcut
   // added depends on the properties in |info|. Calls one of
   // InstallWebApkInBackgroundWithSkBitmap, AddWebappInBackgroundWithSkBitmap,
   // or AddShortcutInBackgroundWithSkBitmap.
-  static void AddToLauncherWithSkBitmap(
-      content::BrowserContext* browser_context,
-      const ShortcutInfo& info,
-      const std::string& webapp_id,
-      const SkBitmap& icon_bitmap,
-      const base::Closure& splash_image_callback);
+  static void AddToLauncherWithSkBitmap(content::WebContents* web_contents,
+                                        const ShortcutInfo& info,
+                                        const SkBitmap& icon_bitmap);
 
   // Installs WebAPK and adds shortcut to the launcher.
   static void InstallWebApkWithSkBitmap(
       content::BrowserContext* browser_context,

[dominickn, 2017/03/01 02:29:39]

Nit: ideally this method should just take a WebContents as well for consistency
with AddToLauncherWithSkBitmap. Can you do that here, it's a fairly small change
(having a WebContents around is generally useful).

       const ShortcutInfo& info,
       const SkBitmap& icon_bitmap,
       const WebApkInstaller::FinishCallback& callback);
 
   // Shows toast notifying user that a WebAPK install is already in progress
   // when user tries to queue a new install for the same WebAPK.
   static void ShowWebApkInstallInProgressToast();
 
   // Returns the ideal size for an icon representing a web app or a WebAPK.
   static int GetIdealHomescreenIconSizeInPx();
@@ skipping 51 matching lines @@
 
   // Fetches information on all the WebAPKs installed on the device and returns
   // the info to the |callback|.
   static void RetrieveWebApks(const WebApkInfoCallback& callback);
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(ShortcutHelper);
 };
 
 #endif  // CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_