mash: improves browser frame decorations

ui/views/mus/desktop_window_tree_host_mus.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/mus/desktop_window_tree_host_mus.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/threading/thread_task_runner_handle.h"
@@ skipping 258 matching lines @@
   if (!auto_update_client_area_)
     return false;
 
   using WIP = views::Widget::InitParams;
   const WIP::Type type = desktop_native_widget_aura_->widget_type();
   return type == WIP::TYPE_WINDOW || type == WIP::TYPE_PANEL;
 }
 
 void DesktopWindowTreeHostMus::Init(aura::Window* content_window,
                                     const Widget::InitParams& params) {
-  // Needed so we don't render over the non-client area the window manager
-  // renders to.
-  content_window->layer()->SetFillsBoundsOpaquely(false);
+  // |TYPE_WINDOW| and |TYPE_PANEL| are forced to transparent as otherwise the
+  // window is opaque and the client decorations drawn by the window manager
+  // would not be seen.
+  const bool transparent =
+      params.opacity == Widget::InitParams::TRANSLUCENT_WINDOW ||
+      params.type == Widget::InitParams::TYPE_WINDOW ||
+      params.type == Widget::InitParams::TYPE_PANEL;
+  content_window->SetTransparent(transparent);
+  window()->SetTransparent(transparent);
+
   if (!params.bounds.IsEmpty())
     SetBoundsInDIP(params.bounds);
 
   cursor_manager_ = base::MakeUnique<wm::CursorManager>(
       base::MakeUnique<NativeCursorManagerMus>(window()));
   aura::client::SetCursorClient(window(), cursor_manager_.get());
   InitHost();
 
   NativeWidgetAura::SetShadowElevationFromInitParams(window(), params);
 
   // Transient parents are connected using the Window created by WindowTreeHost,
   // which is owned by the window manager. This way the window manager can
   // properly identify and honor transients.
   if (params.parent && params.parent->GetHost()) {
     aura::client::GetTransientWindowClient()->AddTransientChild(
         params.parent->GetHost()->window(), window());
   }
 
   if (!params.accept_events) {
     aura::WindowPortMus::Get(window())->SetEventTargetingPolicy(
         ui::mojom::EventTargetingPolicy::NONE);
   }
 }
 
 void DesktopWindowTreeHostMus::OnNativeWidgetCreated(
     const Widget::InitParams& params) {
+  window()->SetName(params.name);
+  desktop_native_widget_aura_->content_window()->SetName(
+      "DesktopNativeWidgetAura - content window");
   if (params.parent && params.parent->GetHost()) {
     parent_ = static_cast<DesktopWindowTreeHostMus*>(params.parent->GetHost());
     parent_->children_.insert(this);
   }
   native_widget_delegate_->OnNativeWidgetCreated(true);
 }
 
 void DesktopWindowTreeHostMus::OnNativeWidgetActivationChanged(bool active) {
   // In Mus, when our aura Window receives an activation signal, it can be
   // because of remote messages. We need to forward that to Widget so that
@@ skipping 485 matching lines @@
     aura::client::FocusClient* focus_client,
     aura::Window* window) {
   if (window == this->window()) {
     desktop_native_widget_aura_->HandleActivationChanged(true);
   } else if (is_active_) {
     desktop_native_widget_aura_->HandleActivationChanged(false);
   }
 }
 
 }  // namespace views