Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 27246004: Remove isDialog() from RenderObject (Closed)

Created:
7 years, 2 months ago by kangil_
Modified:
7 years, 2 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove isDialog() from RenderObject As RenderDialog.h has been removed, this patch deletes unused isDialog function. 3.65K gain on content_shell release build. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/rendering/RenderObject.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
kangil_
review please? :)
7 years, 2 months ago (2013-10-15 13:46:54 UTC) #1
Julien - ping for review
lgtm, the savings seem huge for a dead function.
7 years, 2 months ago (2013-10-15 14:52:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/27246004/1
7 years, 2 months ago (2013-10-15 14:52:46 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=11360
7 years, 2 months ago (2013-10-15 16:09:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/27246004/1
7 years, 2 months ago (2013-10-16 00:08:32 UTC) #5
commit-bot: I haz the power
Change committed as 159705
7 years, 2 months ago (2013-10-16 02:18:47 UTC) #6
esprehn
This one uncalled function produced 3.65k of binary output? I suppose that's not a static ...
7 years, 2 months ago (2013-10-16 04:16:11 UTC) #7
kangil_
On 2013/10/16 04:16:11, esprehn wrote: > This one uncalled function produced 3.65k of binary output? ...
7 years, 2 months ago (2013-10-16 04:36:44 UTC) #8
kangil_
7 years, 2 months ago (2013-10-16 04:43:15 UTC) #9
Message was sent while issue was closed.
On 2013/10/16 04:36:44, kangil_ wrote:
> On 2013/10/16 04:16:11, esprehn wrote:
> > This one uncalled function produced 3.65k of binary output? I suppose that's
> not
> > a static build so the linker didn't get a chance to eliminate it yet?
> 
> To clarify, I am using content_shell executable on my linux(64 bit) desktop
and
> size change was like below. :)
> - 92179552-92175808=3744, 3744/1024=3.65625

Oh, I missed one thing to answer. :)
content_shell depends on content_shell_lib and the type of it is static_library.

Powered by Google App Engine
This is Rietveld 408576698